Fix get.currentMatches() returning [] on initial state with consolation final and 4 participants (#226)

* Fix bug in `get.currentMatches()`

* Add more unit tests

Author: Drarig29

src/get.ts

@@ -162,13 +162,12 @@ export class Get extends BaseGetter {
             currentRoundIndex++;
 
             if (stage.settings.consolationFinal && currentRoundIndex === roundCount - 1) {
-                // We are on the final of the single elimination.
                 const [final] = roundMatches;
                 const [consolationFinal] = matchesByRound[currentRoundIndex + 1];
 
                 const finals = [final, consolationFinal];
                 if (finals.every(match => !helpers.isMatchOngoing(match)))
-                    return [];
+                    return currentMatches;
 
                 return finals.filter(match => helpers.isMatchOngoing(match));
             }

test/unit/get.spec.js

@@ -136,6 +136,48 @@ describe('Unit - get', () => {
                 [{ stage_id: 1, round_id: 100, status: Status.Completed }, { stage_id: 2, round_id: 0, status: Status.Completed }, { stage_id: 2, round_id: 1, status: Status.Completed }],
                 [],
             ],
+            [
+                'one stage - initial state',
+                { id: 2, type: 'single_elimination', settings: { size: 4 } },
+                [{ stage_id: 2, group_id: 0, id: 0 }, { stage_id: 2, group_id: 0, id: 1 }, { stage_id: 2, group_id: 1, id: 2 }],
+                [{ stage_id: 2, round_id: 0, status: Status.Ready }, { stage_id: 2, round_id: 0, status: Status.Ready }, { stage_id: 2, round_id: 1, status: Status.Locked }, { stage_id: 2, round_id: 2, status: Status.Locked }],
+                [{ stage_id: 2, round_id: 0, status: Status.Ready }, { stage_id: 2, round_id: 0, status: Status.Ready }],
+            ],
+            [
+                'one stage - matches of 1st round completed and 2nd round ready',
+                { id: 2, type: 'single_elimination', settings: { size: 4 } },
+                [{ stage_id: 2, group_id: 0, id: 0 }, { stage_id: 2, group_id: 0, id: 1 }, { stage_id: 2, group_id: 1, id: 2 }],
+                [{ stage_id: 2, round_id: 0, status: Status.Completed }, { stage_id: 2, round_id: 0, status: Status.Completed }, { stage_id: 2, round_id: 1, status: Status.Ready }, { stage_id: 2, round_id: 2, status: Status.Locked }],
+                [{ stage_id: 2, round_id: 1, status: Status.Ready }],
+            ],
+            [
+                'one stage - matches of 1st round completed and 2nd round running',
+                { id: 2, type: 'single_elimination', settings: { size: 4 } },
+                [{ stage_id: 2, group_id: 0, id: 0 }, { stage_id: 2, group_id: 0, id: 1 }, { stage_id: 2, group_id: 1, id: 2 }],
+                [{ stage_id: 2, round_id: 0, status: Status.Archived }, { stage_id: 2, round_id: 0, status: Status.Archived }, { stage_id: 2, round_id: 1, status: Status.Running }, { stage_id: 2, round_id: 2, status: Status.Locked }],
+                [{ stage_id: 2, round_id: 1, status: Status.Running }],
+            ],
+            [
+                'one stage, with consolation final - initial state',
+                { id: 2, type: 'single_elimination', settings: { size: 4, consolationFinal: true } },
+                [{ stage_id: 2, group_id: 0, id: 0 }, { stage_id: 2, group_id: 0, id: 1 }, { stage_id: 2, group_id: 1, id: 2 }],
+                [{ stage_id: 2, round_id: 0, status: Status.Ready }, { stage_id: 2, round_id: 0, status: Status.Ready }, { stage_id: 2, round_id: 1, status: Status.Locked }, { stage_id: 2, round_id: 2, status: Status.Locked }],
+                [{ stage_id: 2, round_id: 0, status: Status.Ready }, { stage_id: 2, round_id: 0, status: Status.Ready }],
+            ],
+            [
+                'one stage, with consolation final - matches of 1st round completed and 2nd round ready',
+                { id: 2, type: 'single_elimination', settings: { size: 4, consolationFinal: true } },
+                [{ stage_id: 2, group_id: 0, id: 0 }, { stage_id: 2, group_id: 0, id: 1 }, { stage_id: 2, group_id: 1, id: 2 }],
+                [{ stage_id: 2, round_id: 0, status: Status.Completed }, { stage_id: 2, round_id: 0, status: Status.Completed }, { stage_id: 2, round_id: 1, status: Status.Ready }, { stage_id: 2, round_id: 2, status: Status.Locked }],
+                [{ stage_id: 2, round_id: 1, status: Status.Ready }],
+            ],
+            [
+                'one stage, with consolation final - matches of 1st round completed and 2nd round running',
+                { id: 2, type: 'single_elimination', settings: { size: 4, consolationFinal: true } },
+                [{ stage_id: 2, group_id: 0, id: 0 }, { stage_id: 2, group_id: 0, id: 1 }, { stage_id: 2, group_id: 1, id: 2 }],
+                [{ stage_id: 2, round_id: 0, status: Status.Archived }, { stage_id: 2, round_id: 0, status: Status.Archived }, { stage_id: 2, round_id: 1, status: Status.Running }, { stage_id: 2, round_id: 2, status: Status.Locked }],
+                [{ stage_id: 2, round_id: 1, status: Status.Running }],
+            ],
             [
                 'one stage, with consolation final - both finals running',
                 { id: 2, type: 'single_elimination', settings: { size: 4, consolationFinal: true } },