refactor: Use a flag in UiState instead of passing a callback to the presenter

Author: warahiko

feature/profilecard/src/commonMain/kotlin/io/github/droidkaigi/confsched/profilecard/CropImageScreen.kt

@@ -20,6 +20,7 @@ import androidx.compose.material3.Scaffold
 import androidx.compose.material3.Text
 import androidx.compose.material3.TopAppBar
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableFloatStateOf
 import androidx.compose.runtime.mutableStateOf
@@ -73,6 +74,7 @@ internal sealed interface CropImageScreenState {
 
     data class Confirm(
         val profileImage: ProfileImage,
+        val shouldBack: Boolean,
     ) : CropImageScreenState
 }
 
@@ -83,11 +85,14 @@ internal fun CropImageScreen(
     onConfirm: () -> Unit,
     modifier: Modifier = Modifier,
     eventFlow: EventFlow<CropImageScreenEvent> = rememberEventFlow(),
-    uiState: CropImageScreenState = cropImageScreenPresenter(
-        onConfirm = onConfirm,
-        events = eventFlow,
-    ),
+    uiState: CropImageScreenState = cropImageScreenPresenter(eventFlow),
 ) {
+    LaunchedEffect(uiState is CropImageScreenState.Confirm && uiState.shouldBack) {
+        if (uiState is CropImageScreenState.Confirm && uiState.shouldBack) {
+            onConfirm()
+        }
+    }
+
     Scaffold(
         modifier = modifier.fillMaxSize(),
         topBar = {

feature/profilecard/src/commonMain/kotlin/io/github/droidkaigi/confsched/profilecard/CropImageScreenPresenter.kt

@@ -24,13 +24,13 @@ internal sealed interface CropImageScreenEvent {
 
 @Composable
 internal fun cropImageScreenPresenter(
-    onConfirm: () -> Unit,
     events: Flow<CropImageScreenEvent>,
     repository: ProfileCardRepository = localProfileCardRepository(),
 ): CropImageScreenState = providePresenterDefaults { _ ->
     val profileImageCandidate: ProfileImage? by rememberUpdatedState(repository.profileImageCandidate())
     var croppedProfileImage: ProfileImage? by remember { mutableStateOf(null) }
     var isProcessing: Boolean by remember { mutableStateOf(false) }
+    var shouldBack: Boolean by remember { mutableStateOf(false) }
 
     SafeLaunchedEffect(Unit) {
         events.collect { event ->
@@ -49,7 +49,7 @@ internal fun cropImageScreenPresenter(
                     val result = requireNotNull(croppedProfileImage)
                     repository.setProfileImageInEdit(result)
 
-                    onConfirm()
+                    shouldBack = true
                 }
 
                 is CropImageScreenEvent.Cancel -> {
@@ -76,6 +76,7 @@ internal fun cropImageScreenPresenter(
         else -> {
             CropImageScreenState.Confirm(
                 profileImage = cropped,
+                shouldBack = shouldBack,
             )
         }
     }