Commit b11e22c
committed
docs(gateway): say why the e2e DNS wait is non-zero
`max_dns_wait` was raised from 0 to 5 with nothing saying so, in a suite where
everything else carries its reasoning. It is load-bearing: it is certbot's
pre-order self-check budget, and at 0 the poll loop exits before its first
lookup, so the order goes out assuming the mock DNS API has already served the
record. Harmless while Pebble was not validating challenges; a race now that it
is.1 parent 44e5971 commit b11e22c
1 file changed
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
576 | 576 | | |
577 | 577 | | |
578 | 578 | | |
579 | | - | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
580 | 590 | | |
581 | 591 | | |
582 | 592 | | |
| |||
0 commit comments