Skip to content

Commit b11e22c

Browse files
committed
docs(gateway): say why the e2e DNS wait is non-zero
`max_dns_wait` was raised from 0 to 5 with nothing saying so, in a suite where everything else carries its reasoning. It is load-bearing: it is certbot's pre-order self-check budget, and at 0 the poll loop exits before its first lookup, so the order goes out assuming the mock DNS API has already served the record. Harmless while Pebble was not validating challenges; a race now that it is.
1 parent 44e5971 commit b11e22c

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

dstack/gateway/test-run/e2e/test.sh

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,17 @@ setup_certbot_config() {
576576
return 1
577577
fi
578578

579-
# Create DNS credential
579+
# Create DNS credential.
580+
#
581+
# `max_dns_wait` is non-zero on purpose. It is certbot's pre-order
582+
# self-check budget: it polls the challenge zone's authoritative
583+
# nameservers for the TXT record before asking the CA to validate, and logs
584+
# which record it could not see. At 0 the poll loop exits before its first
585+
# lookup (see `dns_poll_sleep`), so the order goes out on the assumption
586+
# that the mock DNS API has already served the record -- harmless while
587+
# Pebble was not validating challenges, a race now that it is. 5s is ample
588+
# against a mock on the same bridge and sits well inside the clamp in
589+
# `advisory_dns_wait`.
580590
log_info "Creating DNS credential..."
581591
if ! curl -sf -X POST "${GATEWAY_ADMIN}/prpc/Admin.CreateDnsCredential" \
582592
-H "${ADMIN_AUTH_HEADER}" \

0 commit comments

Comments
 (0)