Skip to content

Commit b63fc44

Browse files
committed
refactor(certbot): log the DNS budget at debug, not on every issuance
1 parent 5ef4936 commit b63fc44

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

dstack/certbot/src/acme_client.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -247,11 +247,15 @@ const DNS_WAIT_SHARE_OF_RENEW_TIMEOUT: u32 = 2;
247247
pub fn advisory_dns_wait(configured: Duration, renew_timeout: Duration) -> Duration {
248248
let capped = renew_timeout / DNS_WAIT_SHARE_OF_RENEW_TIMEOUT;
249249
if configured > capped {
250-
// Silently ignoring a configured value leaves an operator raising it
251-
// with no idea why nothing changes.
252-
info!(
253-
"waiting up to {capped:?} for DNS rather than the configured {configured:?}: \
254-
the renewal timeout is {renew_timeout:?}, and the check has to finish inside it"
250+
// At `debug!` deliberately: the stock defaults have both values at 300s,
251+
// so this fires on every issuance in every deployment. Phrased as the
252+
// budget it is rather than as an override, so an operator who does raise
253+
// `max_dns_wait` and finds nothing changed can see why here, without a
254+
// permanent line in everyone else's log implying they configured
255+
// something that was ignored.
256+
debug!(
257+
"DNS check budget is {capped:?}, half of the {renew_timeout:?} renewal timeout; \
258+
the configured wait of {configured:?} does not fit inside it"
255259
);
256260
}
257261
configured.min(capped)

0 commit comments

Comments
 (0)