Merge pull request #353 from DuendeSoftware/dh/need-to-revert-pr-350

Revert PR #350: Override refresh token max length

Author: damianh

access-token-management/src/AccessTokenManagement/RefreshToken.cs

@@ -10,36 +10,13 @@ namespace Duende.AccessTokenManagement;
 [JsonConverter(typeof(StringValueJsonConverter<RefreshToken>))]
 public readonly record struct RefreshToken : IStronglyTypedValue<RefreshToken>
 {
-    private static int? _overriddenMaxLength;
-    private static ValidationRule<string>[] _validators = [];
-
-    // Officially, there's no max length refresh tokens, but 4k is a good limit
     public const int MaxLength = 4 * 1024;
-
-    static RefreshToken() => InitializeValidators();
-
     public override string ToString() => Value;
 
-    /// <summary>
-    /// Changes the maximum length for refresh tokens.
-    /// </summary>
-    /// <param name="maxLength">The new maximum length. Must be a strictly positive value.</param>
-    /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="maxLength"/> is zero or a negative value.</exception>
-    /// <remarks>
-    /// Note that this change is applied statically and will affect all instances of <see cref="RefreshToken"/> across the entire application.
-    /// </remarks>
-    public static void SetMaxLength(int maxLength)
-    {
-        ArgumentOutOfRangeException.ThrowIfNegativeOrZero(maxLength);
-
-        _overriddenMaxLength = maxLength;
-        InitializeValidators();
-    }
-
-    private static void InitializeValidators() =>
-        _validators = [
-            ValidationRules.MaxLength(_overriddenMaxLength ?? MaxLength)
-        ];
+    private static readonly ValidationRule<string>[] Validators = [
+        // Officially, there's no max length refresh tokens, but 4k is a good limit
+        ValidationRules.MaxLength(MaxLength)
+    ];
 
     /// <summary>
     /// You can't directly create this type.
@@ -61,7 +38,7 @@ private static void InitializeValidators() =>
     /// and also includes a list of errors. This is useful for validating user input or other scenarios where you want to provide feedback
     /// </summary>
     public static bool TryParse(string value, [NotNullWhen(true)] out RefreshToken? parsed, out string[] errors) =>
-        IStronglyTypedValue<RefreshToken>.TryBuildValidatedObject(value, _validators, out parsed, out errors);
+        IStronglyTypedValue<RefreshToken>.TryBuildValidatedObject(value, Validators, out parsed, out errors);
 
     static RefreshToken IStronglyTypedValue<RefreshToken>.Create(string result) => new(result);
 

access-token-management/test/AccessTokenManagement.Tests/AccessTokenHandler/AccessTokenHandlerTests.cs

@@ -11,10 +11,6 @@
 
 namespace Duende.AccessTokenManagement.AccessTokenHandler;
 
-// This class uses <see cref="RefreshToken"/>, whose max length is static mutable state
-// (via <see cref="RefreshToken.SetMaxLength"/>). Sharing a collection with the other
-// RefreshToken test classes prevents parallel execution that could cause flaky failures.
-[Collection(nameof(Types.RefreshTokenTests))]
 public class AccessTokenHandlerTests(ITestOutputHelper output)
 {
     private readonly CancellationToken _ct = TestContext.Current.CancellationToken;

access-token-management/test/AccessTokenManagement.Tests/PublicApiVerificationTests.VerifyPublicApi.verified.txt

@@ -184,7 +184,6 @@
         public RefreshToken() { }
         public override string ToString() { }
         public static Duende.AccessTokenManagement.RefreshToken Parse(string value) { }
-        public static void SetMaxLength(int maxLength) { }
         public static bool TryParse(string value, [System.Diagnostics.CodeAnalysis.NotNullWhen(true)] out Duende.AccessTokenManagement.RefreshToken? parsed, out string[] errors) { }
         public static string op_Implicit(Duende.AccessTokenManagement.RefreshToken value) { }
     }

access-token-management/test/AccessTokenManagement.Tests/StoreTokensInAuthenticationPropertiesTests.cs

@@ -10,10 +10,6 @@
 
 namespace Duende.AccessTokenManagement;
 
-// This class uses <see cref="RefreshToken"/>, whose max length is static mutable state
-// (via <see cref="RefreshToken.SetMaxLength"/>). Sharing a collection with the other
-// RefreshToken test classes prevents parallel execution that could cause flaky failures.
-[Collection(nameof(Types.RefreshTokenTests))]
 public class StoreTokensInAuthenticationPropertiesTests
 {
     private readonly CancellationToken _ct = TestContext.Current.CancellationToken;