feat: add a dependency with a glide-plugin to support APNG, animated WebP on Android #834
Conversation
baron-chiu
changed the title
baron-chiu
changed the title
baron-chiu
changed the title
|
@lucalves any update whether this PR will be merged or not, it will help me a lot |
I can't merge because I'm not part of the project's maintainers. I just approved the PR because I didn't see anything wrong. |
|
Just switched my app over to |
|
Maybe some benchmark test and unit test will help? I have little experience in react native. Can I have some suggestions for them? I will add them if I can manage to deliver. |
|
@DylanVann any chance to release this? If any Expo user needs this, I've prepared some config-plugins for you: |
|
@bcgodev this is outdated, use |
Thanks for the reminder. I took a look at I can update the version of |
|
@bcgodev I didn't check on the APNG part, I only need webP support and your implementation lib didn't work for me, but mine did. |
|
@hirbod Hi, just implementation 'com.github.penfeizhou.android.animation:glide-plugin:2.17.0' will resolve your problem, it supports APNG & WEBP both. |
|
Thanks. Are there any benefits with the other library instead of mine, beside of the APNG support? (I don't need APNG) |
@hirbod Can I ask what doesn't work for you with v2.12.0? |
|
The image wasn't animating for me. Didn't try 17 though |
I think it works for https://isparta.github.io/compare-webp/image/gif_webp/webp/2.webp |
fix my problem, thx |
In #673, @ardalahmet provides a simple way to add support of APNG on Android.
Since glide doesn't support APNG,
react-native-fast-imagehasn't supported APNG on Android.However @penfeizhou's APNG4Android provides a glide-plugin to support animation easily. It supports
gif,APNG, andAnimated WebP.This PR simply applies @ardalahmet's suggestion and add it to Android's gradle dependency.
Should there be any concern of adding the glide plugin?
closes #92 #673
related PR: #703 #542