Allow unknown-flags (#29)

Author: 0sewa0

main.go

@@ -42,8 +42,9 @@ func main() {
 
 func bootstrapper(fs afero.Fs) *cobra.Command {
 	cmd := &cobra.Command{
-		Use:  "dynatrace-bootstrapper",
-		RunE: run(fs),
+		Use:                "dynatrace-bootstrapper",
+		RunE:               run(fs),
+		FParseErrWhitelist: cobra.FParseErrWhitelist{UnknownFlags: true},
 	}
 
 	AddFlags(cmd)
@@ -70,6 +71,7 @@ func AddFlags(cmd *cobra.Command) {
 func run(fs afero.Fs) func(cmd *cobra.Command, _ []string) error {
 	return func(cmd *cobra.Command, _ []string) error {
 		setupLogger()
+
 		if isDebug {
 			log.Info("debug logs enabled")
 		}

main_test.go

@@ -40,7 +40,6 @@ func TestBootstrapper(t *testing.T) {
 
 		require.NoError(t, err)
 
-
 		cmd = bootstrapper(afero.NewMemMapFs())
 		// Note: we can't skip/mask the validation of the required flags
 		cmd.SetArgs([]string{"--source", "\\\\", "--target", "\\\\", "--suppress-error", "true"})
@@ -49,4 +48,13 @@ func TestBootstrapper(t *testing.T) {
 
 		require.NoError(t, err)
 	})
+
+	t.Run("should allow unknown flags -> no error", func(t *testing.T) {
+		cmd := bootstrapper(afero.NewMemMapFs())
+		cmd.SetArgs([]string{"--source", "./", "--target", "./", "--unknown", "--flag", "value"})
+
+		err := cmd.Execute()
+
+		require.NoError(t, err)
+	})
 }

pkg/configure/cmd.go

@@ -18,9 +18,9 @@ import (
 )
 
 const (
-	inputFolderFlag  = "input-directory"
-	configFolderFlag = "config-directory"
-	installPathFlag  = "install-path"
+	InputFolderFlag  = "input-directory"
+	ConfigFolderFlag = "config-directory"
+	InstallPathFlag  = "install-path"
 )
 
 var (
@@ -33,11 +33,11 @@ var (
 )
 
 func AddFlags(cmd *cobra.Command) {
-	cmd.PersistentFlags().StringVar(&inputFolder, inputFolderFlag, "", "(Optional) Base path where to look for the configuration files.")
+	cmd.PersistentFlags().StringVar(&inputFolder, InputFolderFlag, "", "(Optional) Base path where to look for the configuration files.")
 
-	cmd.PersistentFlags().StringVar(&configFolder, configFolderFlag, "", "(Optional) Base path where to put the configuration files.")
+	cmd.PersistentFlags().StringVar(&configFolder, ConfigFolderFlag, "", "(Optional) Base path where to put the configuration files.")
 
-	cmd.PersistentFlags().StringVar(&installPath, installPathFlag, "/opt/dynatrace/oneagent", "(Optional) Base path where the agent binary will be put.")
+	cmd.PersistentFlags().StringVar(&installPath, InstallPathFlag, "/opt/dynatrace/oneagent", "(Optional) Base path where the agent binary will be put.")
 
 	cmd.PersistentFlags().StringArrayVar(&containerAttributes, container.Flag, []string{}, "(Optional) Container-specific attributes in JSON format.")