feat: manifest.Load(...) includes unselected environments as not enabled environments with Enabled: false

In order to be able to check environment and group overrides in `project.LoadProject(...)` they need not to be removed in `manifest.Load(...)`. Instead, this function marks them as not enabled, with `Enabled: false`.

Author: arthurpitman

cmd/monaco/dynatrace/dynatrace.go

@@ -51,6 +51,9 @@ func VerifyEnvironmentGeneration(ctx context.Context, envs manifest.Environments
 		return true
 	}
 	for _, env := range envs {
+		if !env.Enabled {
+			continue
+		}
 		if !isValidEnvironment(ctx, env) {
 			return false
 		}
@@ -187,6 +190,9 @@ func (e EnvironmentClients) Names() []string {
 func CreateEnvironmentClients(ctx context.Context, environments manifest.Environments, dryRun bool) (EnvironmentClients, error) {
 	clients := make(EnvironmentClients, len(environments))
 	for _, env := range environments {
+		if !env.Enabled {
+			continue
+		}
 		if dryRun {
 			clients[EnvironmentInfo{
 				Name:  env.Name,

cmd/monaco/dynatrace/dynatrace_test.go

@@ -67,15 +67,17 @@ func TestVerifyEnvironmentGeneration_OneOfManyFails(t *testing.T) {
 
 	ok := VerifyEnvironmentGeneration(t.Context(), manifest.Environments{
 		"env": manifest.EnvironmentDefinition{
-			Name: "env",
+			Enabled: true,
+			Name:    "env",
 			URL: manifest.URLDefinition{
 				Type:  manifest.ValueURLType,
 				Name:  "URL",
 				Value: server.URL,
 			},
 		},
 		"env2": manifest.EnvironmentDefinition{
-			Name: "env",
+			Enabled: true,
+			Name:    "env",
 			URL: manifest.URLDefinition{
 				Type:  manifest.ValueURLType,
 				Name:  "URL",
@@ -130,7 +132,8 @@ func TestVerifyEnvironmentGen(t *testing.T) {
 
 		ok := VerifyEnvironmentGeneration(t.Context(), manifest.Environments{
 			"env": manifest.EnvironmentDefinition{
-				Name: "env",
+				Enabled: true,
+				Name:    "env",
 				URL: manifest.URLDefinition{
 					Type:  manifest.ValueURLType,
 					Name:  "URL",
@@ -163,7 +166,8 @@ func TestVerifyEnvironmentGen(t *testing.T) {
 
 		ok := VerifyEnvironmentGeneration(t.Context(), manifest.Environments{
 			"env": manifest.EnvironmentDefinition{
-				Name: "env",
+				Enabled: true,
+				Name:    "env",
 				URL: manifest.URLDefinition{
 					Type:  manifest.ValueURLType,
 					Name:  "URL",
@@ -202,7 +206,8 @@ func TestVerifyEnvironmentGen(t *testing.T) {
 
 		ok := VerifyEnvironmentGeneration(t.Context(), manifest.Environments{
 			"env1": manifest.EnvironmentDefinition{
-				Name: "env1",
+				Enabled: true,
+				Name:    "env1",
 				URL: manifest.URLDefinition{
 					Type:  manifest.ValueURLType,
 					Name:  "URL",
@@ -214,7 +219,8 @@ func TestVerifyEnvironmentGen(t *testing.T) {
 
 		ok = VerifyEnvironmentGeneration(t.Context(), manifest.Environments{
 			"env2": manifest.EnvironmentDefinition{
-				Name: "env2",
+				Enabled: true,
+				Name:    "env2",
 				URL: manifest.URLDefinition{
 					Type:  manifest.ValueURLType,
 					Name:  "URL",