Skip to content

Commit e7633b1

Browse files
committed
fix(settings): Fix possible bucket not found error due to not updated datasource
Some endpoints/services use a different endpoint in order to get/validate the buckets, and this could result in a possible not found error, even though our datasource tells us that the bucket is available
1 parent c070d48 commit e7633b1

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/deploy/internal/setting/setting.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ func Deploy(ctx context.Context, settingsClient client.SettingsClient, propertie
6767
}
6868

6969
if c.HasRefTo(string(config.BucketTypeID)) {
70-
upsertOptions.OverrideRetry = &dtclient.RetrySetting{WaitTime: 10 * time.Second, MaxRetries: 6}
70+
// some endpoints have a different datasource for the buckets, so it may take a while in order to show up
71+
// 6 retries (1 minute) is too less and results in some flakiness
72+
upsertOptions.OverrideRetry = &dtclient.RetrySetting{WaitTime: 10 * time.Second, MaxRetries: 12}
7173
}
7274

7375
if c.HasRefTo(api.ApplicationWeb) {

0 commit comments

Comments
 (0)