Skip to content

Commit a0a82e2

Browse files
committed
Address readiness serving review feedback
1 parent 10b879a commit a0a82e2

3 files changed

Lines changed: 14 additions & 2 deletions

File tree

docs/ai-plans/2026-06-06-issue-166-readiness-serving-freshness-contract.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<body>
2020
<main>
2121
<h1>Implementation Plan: Issue #166 Readiness Serving/Freshness Contract</h1>
22-
<p class="badge">Approval required before implementation</p>
22+
<p class="badge">Approved and implemented</p>
2323

2424
<section>
2525
<h2>Task Summary</h2>

internal/health/readiness.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,9 @@ func readinessServingState(confidence, reason string, components []ReadinessComp
379379
confidence = ReadinessConfidenceFinal
380380
}
381381
status := ReadinessServingFresh
382-
if hasComponentFreshness(components, ReadinessFreshnessMissing) || reason == "missing_same_day_evidence" {
382+
if len(components) == 0 && reason == "" {
383+
status = ReadinessServingMissing
384+
} else if hasComponentFreshness(components, ReadinessFreshnessMissing) || reason == "missing_same_day_evidence" {
383385
status = ReadinessServingMissing
384386
} else if hasComponentFreshness(components, ReadinessFreshnessStale) {
385387
status = ReadinessServingStale

internal/health/readiness_evidence_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,16 @@ func TestReadinessServingState_MissingCoreComponentWins(t *testing.T) {
178178
}
179179
}
180180

181+
func TestReadinessServingState_EvidenceFreeInputIsMissing(t *testing.T) {
182+
state := readinessServingState(ReadinessConfidenceFinal, "", nil)
183+
if state.Status != ReadinessServingMissing {
184+
t.Fatalf("status = %q, want missing", state.Status)
185+
}
186+
if state.Confidence != ReadinessConfidenceFinal {
187+
t.Fatalf("confidence = %q, want final", state.Confidence)
188+
}
189+
}
190+
181191
func TestComputeBriefing_ExposesReadinessServingContract(t *testing.T) {
182192
d := RawMetrics{
183193
LastDate: "2026-06-04",

0 commit comments

Comments
 (0)