Address check-in SLA review feedback

Author: dzarlax

internal/storage/subjective_checkin.go

@@ -368,27 +368,8 @@ func (s *DB) GetCheckinCoverage(today, source string, days int) (*CheckinCoverag
 	}
 	defer rows.Close()
 
-	var entries []CheckinRow
-	for rows.Next() {
-		row := CheckinRow{}
-		var answer *string
-		var msgID *int64
-		var answeredAt *time.Time
-		if err := rows.Scan(&row.Date, &row.Source, &row.Status, &answer, &msgID, &row.PromptedAt, &answeredAt, &row.ExpiresAt); err != nil {
-			return nil, err
-		}
-		if answer != nil {
-			row.Answer = *answer
-		}
-		if msgID != nil {
-			row.PromptMessageID = *msgID
-		}
-		if answeredAt != nil {
-			row.AnsweredAt = *answeredAt
-		}
-		entries = append(entries, row)
-	}
-	if err := rows.Err(); err != nil {
+	entries, err := scanCheckinRows(rows)
+	if err != nil {
 		return nil, err
 	}
 	coverage, err := buildCheckinCoverage(today, source, days, entries)
@@ -420,7 +401,10 @@ func (s *DB) getCheckinRowsBetween(ctx context.Context, source, from, to string)
 		return nil, err
 	}
 	defer rows.Close()
+	return scanCheckinRows(rows)
+}
 
+func scanCheckinRows(rows pgx.Rows) ([]CheckinRow, error) {
 	var entries []CheckinRow
 	for rows.Next() {
 		row := CheckinRow{}
@@ -476,25 +460,9 @@ func buildCheckinCoverage(today, source string, days int, entries []CheckinRow)
 	var latencyN int64
 	promptedDays := 0
 	for _, entry := range entries {
-		promptedAt := entry.PromptedAt
-		expiresAt := entry.ExpiresAt
-		row := CheckinCoverageRow{
-			Date:       entry.Date,
-			Source:     entry.Source,
-			Status:     entry.Status,
-			Answer:     entry.Answer,
-			PromptedAt: &promptedAt,
-			ExpiresAt:  &expiresAt,
-		}
-		if !entry.AnsweredAt.IsZero() {
-			answeredAt := entry.AnsweredAt
-			row.AnsweredAt = &answeredAt
-			latency := int64(answeredAt.Sub(promptedAt).Seconds())
-			if latency < 0 {
-				latency = 0
-			}
-			row.ResponseLatencySeconds = &latency
-			latencySum += latency
+		row := checkinCoverageRow(entry)
+		if row.ResponseLatencySeconds != nil {
+			latencySum += *row.ResponseLatencySeconds
 			latencyN++
 		}
 		switch entry.Status {

internal/ui/admin_checkin_coverage_test.go

@@ -141,6 +141,21 @@ func TestAdminCheckinCoverage_PostRejectsBadEnabledSince(t *testing.T) {
 	}
 }
 
+func TestAdminCheckinCoverage_PostRejectsUnknownFields(t *testing.T) {
+	db, schema, cleanup := testTenantDB(t)
+	defer cleanup()
+
+	h := &Handler{}
+	w := httptest.NewRecorder()
+	r := httptest.NewRequest(http.MethodPost, "/api/admin/checkin-coverage", bytes.NewBufferString(`{"enabled_since":"2026-06-15","extra":true}`)).
+		WithContext(adminContext(db, schema))
+	h.adminCheckinCoverage(w, r)
+
+	if w.Code != http.StatusBadRequest {
+		t.Fatalf("status = %d, want 400; body=%s", w.Code, w.Body.String())
+	}
+}
+
 func TestAdminCheckinCoverage_RejectsBadDays(t *testing.T) {
 	w := httptest.NewRecorder()
 	r := httptest.NewRequest(http.MethodGet, "/api/admin/checkin-coverage?days=0", nil)

internal/ui/handler.go

@@ -6,6 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"html/template"
+	"io"
 	"math"
 	"net"
 	"net/http"
@@ -2887,7 +2888,14 @@ func (h *Handler) adminCheckinCoverage(w http.ResponseWriter, r *http.Request) {
 		var req struct {
 			EnabledSince string `json:"enabled_since"`
 		}
-		if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
+		const maxBodyBytes = 1024
+		dec := json.NewDecoder(http.MaxBytesReader(w, r.Body, maxBodyBytes))
+		dec.DisallowUnknownFields()
+		if err := dec.Decode(&req); err != nil {
+			http.Error(w, "invalid JSON", http.StatusBadRequest)
+			return
+		}
+		if err := dec.Decode(&struct{}{}); err != io.EOF {
 			http.Error(w, "invalid JSON", http.StatusBadRequest)
 			return
 		}

internal/ui/i18n_en.go

@@ -375,6 +375,7 @@ var translationsEn = map[string]string{
 	"admin_checkin_calendar_sla":      "Calendar SLA",
 	"admin_checkin_history":           "Latest prompt history",
 	"admin_checkin_sla_inactive":      "Set an enabled-since date to start calendar SLA checks.",
+	"admin_checkin_save_failed":       "Failed to save check-in SLA date",
 	"admin_checkin_total":             "Days",
 	"admin_checkin_prompted_coverage": "Prompted",
 	"admin_checkin_answered_coverage": "Answered",
@@ -393,6 +394,7 @@ var translationsEn = map[string]string{
 	"admin_checkin_status_pending":    "Pending",
 	"admin_save":                      "Save",
 	"admin_saved":                     "Saved",
+	"admin_saving":                    "Saving...",
 
 	// ─── Admin: AI briefing settings ───────────────────────────
 	"admin_ai_title":      "AI Morning Briefing",

internal/ui/i18n_ru.go

@@ -353,6 +353,7 @@ var translationsRu = map[string]string{
 	"admin_checkin_calendar_sla":      "Календарный SLA",
 	"admin_checkin_history":           "История промптов",
 	"admin_checkin_sla_inactive":      "Укажите дату включения, чтобы начать календарные SLA-проверки.",
+	"admin_checkin_save_failed":       "Не удалось сохранить дату SLA check-in",
 	"admin_checkin_total":             "Дней",
 	"admin_checkin_prompted_coverage": "Промпт был",
 	"admin_checkin_answered_coverage": "Ответ был",
@@ -371,6 +372,7 @@ var translationsRu = map[string]string{
 	"admin_checkin_status_pending":    "Ждём",
 	"admin_save":                      "Сохранить",
 	"admin_saved":                     "Сохранено",
+	"admin_saving":                    "Сохраняем...",
 
 	"admin_ai_title":      "AI-брифинг утром",
 	"admin_ai_key":        "Gemini API ключ",

internal/ui/i18n_sr.go

@@ -334,6 +334,7 @@ var translationsSr = map[string]string{
 	"admin_checkin_calendar_sla":                "Kalendarski SLA",
 	"admin_checkin_history":                     "Istorija promptova",
 	"admin_checkin_sla_inactive":                "Unesite datum uključivanja da počnu kalendarske SLA provere.",
+	"admin_checkin_save_failed":                 "Čuvanje SLA datuma check-ina nije uspelo",
 	"admin_checkin_total":                       "Dana",
 	"admin_checkin_prompted_coverage":           "Prompt poslat",
 	"admin_checkin_answered_coverage":           "Odgovoreno",
@@ -352,6 +353,7 @@ var translationsSr = map[string]string{
 	"admin_checkin_status_pending":              "Čeka se",
 	"admin_save":                                "Sačuvaj",
 	"admin_saved":                               "Sačuvano",
+	"admin_saving":                              "Čuvanje...",
 	"admin_ai_title":                            "AI jutarnji izveštaj",
 	"admin_ai_key":                              "Gemini API ključ",
 	"admin_ai_model":                            "Model",

internal/ui/templates/pages/admin.html

@@ -885,14 +885,14 @@
   var input = $('checkin-enabled-since');
   var msg = $('checkin-enabled-msg');
   if (!input) return;
-  if (msg) msg.textContent = '...';
+  if (msg) msg.textContent = '{{T .Lang "admin_saving"}}';
   fetchWithAdminSchema('/api/admin/checkin-coverage?days=14', {
     method: 'POST',
     headers: {'Content-Type': 'application/json'},
     body: JSON.stringify({enabled_since: input.value || ''})
   })
     .then(function(r){
-      if (!r.ok) return r.text().then(function(t){ throw new Error(t || 'Failed to save check-in SLA date'); });
+      if (!r.ok) return r.text().then(function(t){ throw new Error(t || '{{T .Lang "admin_checkin_save_failed"}}'); });
       return r.json();
     })
     .then(function(d) {