Address Telegram rich report review comments

Author: dzarlax

internal/notify/report_rich.go

@@ -156,12 +156,16 @@ func renderRichHeadline(sb *strings.Builder, h *health.HeadlineSignal) {
 func renderRichMorningSummary(sb *strings.Builder, b *health.BriefingResponse, f freshness, lang string) {
 	sleepValue := "—"
 	sleepRead := tr(lang, "tg_warn_no_sleep")
-	if b.Sleep != nil {
+	if f.sleepStale() && f.sleepKnown {
+		sleepRead = fmt.Sprintf(tr(lang, "tg_sleep_silence"), fmtSilence(f.sleep, lang))
+	} else if b.Sleep != nil {
 		sleepValue = fmt.Sprintf("%.1fh", b.Sleep.TotalAvg)
 		sleepRead = sectionSummary(findSection(b, "sleep"))
 	}
+	recoveryValue := fmt.Sprintf("%d%%", b.RecoveryPct)
 	recoveryRead := sectionSummary(findSection(b, "recovery"))
 	if f.watchOff() && f.watchKnown {
+		recoveryValue = "—"
 		recoveryRead = fmt.Sprintf(tr(lang, "tg_watch_off"), fmtSilence(f.watch, lang))
 	}
 	energyValue, energyRead := "—", "—"
@@ -174,7 +178,7 @@ func renderRichMorningSummary(sb *strings.Builder, b *health.BriefingResponse, f
 	fmt.Fprintf(sb, "<tr><td>⚡ %s</td><td>%s</td><td>%s</td></tr>\n", richEsc(tr(lang, "tg_energy")), richEsc(energyValue), richText(energyRead))
 	fmt.Fprintf(sb, "<tr><td>%s %s</td><td>%d/100</td><td>%s</td></tr>\n", richEsc(readinessEmoji(b.ReadinessToday)), richEsc(tr(lang, "tg_readiness")), b.ReadinessToday, richText(b.ReadinessTodayLabel))
 	fmt.Fprintf(sb, "<tr><td>😴 Sleep</td><td>%s</td><td>%s</td></tr>\n", richEsc(sleepValue), richText(stripSimpleTags(sleepRead)))
-	fmt.Fprintf(sb, "<tr><td>❤️ Recovery</td><td>%d%%</td><td>%s</td></tr>\n", b.RecoveryPct, richText(stripSimpleTags(recoveryRead)))
+	fmt.Fprintf(sb, "<tr><td>❤️ Recovery</td><td>%s</td><td>%s</td></tr>\n", richEsc(recoveryValue), richText(stripSimpleTags(recoveryRead)))
 	sb.WriteString("</table>\n")
 }
 

internal/notify/report_test.go

@@ -196,6 +196,28 @@ func TestFormatMorningRich_StructureAndEscaping(t *testing.T) {
 	}
 }
 
+func TestFormatMorningRich_SuppressesStaleSummaryMetrics(t *testing.T) {
+	loc, _ := time.LoadLocation("UTC")
+	briefing := sampleBriefing()
+	out := formatMorningRich(briefing, nil, "en", loc, freshness{
+		sleep:      48 * time.Hour,
+		watch:      48 * time.Hour,
+		sleepKnown: true,
+		watchKnown: true,
+	}, false, "")
+
+	for _, staleValue := range []string{"7.3h", "68%"} {
+		if strings.Contains(out, staleValue) {
+			t.Fatalf("rich summary should suppress stale value %q:\n%s", staleValue, out)
+		}
+	}
+	for _, want := range []string{"No sleep recorded", "Apple Watch off"} {
+		if !strings.Contains(out, want) {
+			t.Fatalf("rich summary should include stale banner %q:\n%s", want, out)
+		}
+	}
+}
+
 func TestFormatEveningRich_TodayTable(t *testing.T) {
 	loc, _ := time.LoadLocation("UTC")
 	now := time.Now().In(loc).Format("2006-01-02")

internal/notify/telegram.go

@@ -91,7 +91,10 @@ func (b *Bot) SendRichHTML(html string) error {
 		return fmt.Errorf("telegram sendRichMessage: %w", err)
 	}
 	defer resp.Body.Close()
-	body, _ := io.ReadAll(resp.Body)
+	body, readErr := io.ReadAll(resp.Body)
+	if readErr != nil {
+		return fmt.Errorf("telegram sendRichMessage: read body: %w", readErr)
+	}
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("telegram API: status %d body=%s", resp.StatusCode, body)
 	}