Skip to content

Commit cbbcc32

Browse files
authored
Show full model descriptions
Summary: - remove compact catalog description clamping - render full model descriptions directly in compact rows Tests: - go test -count=1 ./internal/adminapi - go test -count=1 ./...
1 parent 64c3841 commit cbbcc32

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

internal/adminapi/adminapi_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,8 @@ func TestModelsBrowserRendersCardAndTableModes(t *testing.T) {
209209
if !strings.Contains(html, "Balanced multilingual model") {
210210
t.Fatalf("compact view missing model description: %s", html)
211211
}
212-
if !strings.Contains(html, "<details class=\"catalog-row__description\">") || !strings.Contains(html, "catalog-row__description-full") {
213-
t.Fatalf("compact view should render expandable full description: %s", html)
212+
if strings.Contains(html, "<details class=\"catalog-row__description\">") || strings.Contains(html, "catalog-row__description-full") {
213+
t.Fatalf("compact view should render full description without expandable clamp: %s", html)
214214
}
215215
if strings.Contains(html, "catalog-audit-table") {
216216
t.Fatalf("compact view should not render audit table")

internal/adminapi/templates/partials_layout.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@
4343
.catalog-row__name { margin-top: 0.12rem; color: var(--text-secondary); font-size: 0.78rem; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
4444
.catalog-row__chips { display: flex; gap: 0.3rem; flex-wrap: wrap; }
4545
.catalog-row__description { margin-top: 0.4rem; color: var(--text-secondary); font-size: 0.8rem; line-height: 1.35; }
46-
.catalog-row__description summary { cursor: pointer; display: -webkit-box; -webkit-line-clamp: 2; -webkit-box-orient: vertical; overflow: hidden; list-style: none; }
47-
.catalog-row__description summary::-webkit-details-marker { display: none; }
48-
.catalog-row__description summary::after { content: " More"; color: var(--accent); font-weight: 600; white-space: nowrap; }
49-
.catalog-row__description[open] summary { display: none; }
50-
.catalog-row__description-full { color: var(--text-secondary); }
5146
.catalog-row__why { font-size: 0.86rem; color: var(--text); }
5247
.catalog-row__reasons, .catalog-row__warnings { display: flex; gap: 0.35rem; flex-wrap: wrap; margin-top: 0.4rem; font-size: 0.78rem; }
5348
.catalog-row__reasons { color: var(--text-secondary); }
@@ -117,7 +112,6 @@
117112
.catalog-view-toggle .btn, .catalog-tabs .btn { flex: 1 1 auto; }
118113
.catalog-sort, .catalog-sort-dir { flex: 1 1 8rem; width: auto; }
119114
.catalog-row { grid-template-columns: 1fr; gap: 0.65rem; }
120-
.catalog-row__description summary { -webkit-line-clamp: 3; }
121115
.catalog-grid { grid-template-columns: 1fr; }
122116
.catalog-card { padding: 0.75rem; }
123117
.catalog-card__header { flex-direction: column; gap: 0.5rem; }

internal/adminapi/templates/partials_models_row.html

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,7 @@
7676
</div>
7777
</div>
7878
{{if .Description}}
79-
<details class="catalog-row__description">
80-
<summary>{{.Description}}</summary>
81-
<div class="catalog-row__description-full">{{.Description}}</div>
82-
</details>
79+
<div class="catalog-row__description">{{.Description}}</div>
8380
{{end}}
8481
</div>
8582

0 commit comments

Comments
 (0)