Merge branch 'jgfouca/gw_cleanup_round' into master (PR #7827)

Some cleanup and bfb fixes in EAMxx gw.

Change list:
1) Remove redundant gw_ from file names
2) Move all constants into constant struct in Functions
3) Add a tol for some front bfb unit tests
4) Another small EKAT update to bring in h2d|d2h improvements.

This should fix CI issues with small round-off-level diffs.

[BFB]

* jgfouca/gw_cleanup_round:
  GPU didn't like this constant for some reason
  Go ahead and update EKAT too
  Tol needed in a couple places
  A last round of easy cleanup for the GW port

Author: jgfouca

components/eamxx/src/physics/gw/CMakeLists.txt

@@ -5,29 +5,29 @@ set(GW_SRCS
 # Add ETI source files if not on CUDA/HIP
 if (NOT EAMXX_ENABLE_GPU OR Kokkos_ENABLE_CUDA_RELOCATABLE_DEVICE_CODE OR Kokkos_ENABLE_HIP_RELOCATABLE_DEVICE_CODE)
   list(APPEND GW_SRCS
-    eti/gw_gwd_compute_tendencies_from_stress_divergence.cpp
-    eti/gw_gw_prof.cpp
+    eti/gw_compute_tendencies_from_stress_divergence.cpp
+    eti/gw_prof.cpp
     eti/gw_momentum_energy_conservation.cpp
-    eti/gw_gwd_compute_stress_profiles_and_diffusivities.cpp
-    eti/gw_gwd_project_tau.cpp
-    eti/gw_gwd_precalc_rhoi.cpp
-    eti/gw_gw_drag_prof.cpp
-    eti/gw_gw_front_project_winds.cpp
-    eti/gw_gw_front_gw_sources.cpp
-    eti/gw_gw_cm_src.cpp
-    eti/gw_gw_convect_project_winds.cpp
-    eti/gw_gw_heating_depth.cpp
-    eti/gw_gw_storm_speed.cpp
-    eti/gw_gw_convect_gw_sources.cpp
-    eti/gw_gw_beres_src.cpp
-    eti/gw_gw_ediff.cpp
-    eti/gw_gw_diff_tend.cpp
-    eti/gw_gw_oro_src.cpp
-    eti/gw_gw_common_init.cpp
+    eti/gw_compute_stress_profiles_and_diffusivities.cpp
+    eti/gw_project_tau.cpp
+    eti/gw_precalc_rhoi.cpp
+    eti/gw_drag_prof.cpp
+    eti/gw_front_project_winds.cpp
+    eti/gw_front_gw_sources.cpp
+    eti/gw_cm_src.cpp
+    eti/gw_convect_project_winds.cpp
+    eti/gw_heating_depth.cpp
+    eti/gw_storm_speed.cpp
+    eti/gw_convect_gw_sources.cpp
+    eti/gw_beres_src.cpp
+    eti/gw_ediff.cpp
+    eti/gw_diff_tend.cpp
+    eti/gw_oro_src.cpp
+    eti/gw_common_init.cpp
     eti/gw_vd_lu_decomp.cpp
     eti/gw_vd_lu_solve.cpp
-    eti/gw_gw_convect_init.cpp
-    eti/gw_gw_front_init.cpp
+    eti/gw_convect_init.cpp
+    eti/gw_front_init.cpp
   ) # GW ETI SRCS
 endif()
 

components/eamxx/src/physics/gw/eti/gw_gw_beres_src.cpp renamed to components/eamxx/src/physics/gw/eti/gw_beres_src.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gw_beres_src_impl.hpp"
+#include "impl/gw_beres_src_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gw_cm_src.cpp renamed to components/eamxx/src/physics/gw/eti/gw_cm_src.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gw_cm_src_impl.hpp"
+#include "impl/gw_cm_src_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gw_common_init.cpp renamed to components/eamxx/src/physics/gw/eti/gw_common_init.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gw_common_init_impl.hpp"
+#include "impl/gw_common_init_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gwd_compute_stress_profiles_and_diffusivities.cpp renamed to components/eamxx/src/physics/gw/eti/gw_compute_stress_profiles_and_diffusivities.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gwd_compute_stress_profiles_and_diffusivities_impl.hpp"
+#include "impl/gw_compute_stress_profiles_and_diffusivities_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gwd_compute_tendencies_from_stress_divergence.cpp renamed to components/eamxx/src/physics/gw/eti/gw_compute_tendencies_from_stress_divergence.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gwd_compute_tendencies_from_stress_divergence_impl.hpp"
+#include "impl/gw_compute_tendencies_from_stress_divergence_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gw_convect_gw_sources.cpp renamed to components/eamxx/src/physics/gw/eti/gw_convect_gw_sources.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gw_convect_gw_sources_impl.hpp"
+#include "impl/gw_convect_gw_sources_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gw_convect_init.cpp renamed to components/eamxx/src/physics/gw/eti/gw_convect_init.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gw_convect_init_impl.hpp"
+#include "impl/gw_convect_init_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gw_convect_project_winds.cpp renamed to components/eamxx/src/physics/gw/eti/gw_convect_project_winds.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gw_convect_project_winds_impl.hpp"
+#include "impl/gw_convect_project_winds_impl.hpp"
 
 namespace scream {
 namespace gw {

components/eamxx/src/physics/gw/eti/gw_gw_diff_tend.cpp renamed to components/eamxx/src/physics/gw/eti/gw_diff_tend.cpp

@@ -1,4 +1,4 @@
-#include "impl/gw_gw_diff_tend_impl.hpp"
+#include "impl/gw_diff_tend_impl.hpp"
 
 namespace scream {
 namespace gw {