EAMxx: fix cld fraction unit test to work also with cupy #7716
+147
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
force-pushed
the
bartgol/eamxx/cld-frac-py-fix
branch
from
0817042 to
908ecc2
Compare
Contributor
Author
|
I just updated out snl containers to contain all the needed torch/cuda libs. They will be patched by the AT2 buildfarm tonight, and become available for use tomorrow. I'll retest then. |
bartgol
force-pushed
the
bartgol/eamxx/cld-frac-py-fix
branch
from
908ecc2 to
7fee2a5
Compare
bartgol
force-pushed
the
bartgol/eamxx/cld-frac-py-fix
branch
from
7fee2a5 to
3167277
Compare
bartgol
force-pushed
the
bartgol/eamxx/cld-frac-py-fix
branch
from
3167277 to
4b4a7e5
Compare
Contributor
Author
|
Build still failing b/c the containers were not yet updated. I fixed the recipe, but did not correctly trigger the rebuild of the images, so the AT is still picking up the old image. I fixed it now, but may not get the correct image until tomorrow night. Will retrigger once the AT container image is updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a version of the cld_fraction_standalone test that uses cupy.
[BFB]
This PR needs to wait a bit, since I need to update the snl cuda image to also have cupy installed. I am starting to put the PR up so I don't forget to put it past the finish line when the AT2 cuda image is updated.