Skip to content

Conversation

@singhbalwinder
Copy link
Contributor

A new test is added to the MAM4xx test suite that runs the MAM4xx's constituent fluxes process in isolation.

[BFB]

@singhbalwinder singhbalwinder self-assigned this Nov 12, 2025
@singhbalwinder singhbalwinder added BFB PR leaves answers BFB Testing Anything related to unit/system tests EAMxx C++ based E3SM atmosphere model (aka SCREAM) MAM4xx MAM4xx related changes labels Nov 12, 2025
Copilot finished reviewing on behalf of singhbalwinder November 12, 2025 01:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CIME test for the MAM4xx constituent_fluxes process, enabling isolated testing of this process similar to other MAM4xx processes.

  • Adds constituent_fluxes test configuration with shell_commands file to set up the process
  • Registers the test in both the lowres and lowres_debug MAM4xx test suites

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
components/eamxx/cime_config/testdefs/testmods_dirs/eamxx/mam4xx/constituent_fluxes/shell_commands New shell commands file configuring the mam4_constituent_fluxes process with mac_aero_mic and rrtmgp for CIME testing
cime_config/tests.py Adds REP_Ln5 and SMS_D_Ln5 test entries for constituent_fluxes to the MAM4xx lowres and lowres_debug test suites

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

#------------------------------------------------------
# Set rest of the options to default
#------------------------------------------------------
$CIMEROOT/../components/eamxx/cime_config/testdefs/testmods_dirs/eamxx/mam4xx/set_default_eamxx_options No newline at end of file
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at end of file. Shell scripts should end with a newline character for better compatibility with Unix tools and version control systems.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BFB PR leaves answers BFB EAMxx C++ based E3SM atmosphere model (aka SCREAM) MAM4xx MAM4xx related changes Testing Anything related to unit/system tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants