Merge pull request #398 from E3SM-Project/bartgol/expression-templates-fix

Nano fix for rank-0 expressions

Author: bartgol

src/expression/ekat_expression_eval.hpp

@@ -24,8 +24,8 @@ void evaluate (const Expression<Derived>& e, const ViewT& result)
   using Policy1D = Kokkos::RangePolicy<exec_space>;
   using PolicyMD = Kokkos::MDRangePolicy<exec_space,Kokkos::Rank<N>>;
 
-  int beg[N] = {0};
-  int end[N];
+  int beg[N] = {};
+  int end[N] = {};
   for (int i=0; i<N; ++i) end[i] = result.extent(i);
 
   // Cast now, and capture the derived obj in the lambda, to make sure we get the

tests/expression/expressions.cpp

@@ -91,14 +91,27 @@ TEST_CASE("expressions", "") {
   std::uniform_real_distribution<Real> pdf(0.1, 1);
 
   using kk_t = KokkosTypes<DefaultDevice>;
+  SECTION ("0d") {
+    kk_t::view_ND<Real,0> x("x");
+    kk_t::view_ND<Real,0> y("y");
+    kk_t::view_ND<Real,0> z("z");
+
+    genRandArray(x,engine,pdf);
+    genRandArray(y,engine,pdf);
+
+    bin_ops(x,y,z);
+    math_fcns(x,y,z);
+    conditionals(x,y,z);
+  }
+
   SECTION ("1d") {
     kk_t::view_1d<Real> x("x",1000);
     kk_t::view_1d<Real> y("y",1000);
     kk_t::view_1d<Real> z("z",1000);
 
     genRandArray(x,engine,pdf);
     genRandArray(y,engine,pdf);
-    
+
     bin_ops(x,y,z);
     math_fcns(x,y,z);
     conditionals(x,y,z);
@@ -111,7 +124,7 @@ TEST_CASE("expressions", "") {
 
     genRandArray(x,engine,pdf);
     genRandArray(y,engine,pdf);
-    
+
     bin_ops(x,y,z);
     math_fcns(x,y,z);
     conditionals(x,y,z);
@@ -124,7 +137,7 @@ TEST_CASE("expressions", "") {
 
     genRandArray(x,engine,pdf);
     genRandArray(y,engine,pdf);
-    
+
     bin_ops(x,y,z);
     math_fcns(x,y,z);
     conditionals(x,y,z);