Fix return type decl for binary math fcn expression

bartgol · bartgol · commit e1553cd828ee · 2025-11-07T09:11:11.000-07:00
diff --git a/src/expression/ekat_expression_math.hpp b/src/expression/ekat_expression_math.hpp
@@ -22,9 +22,7 @@ namespace ekat {
                                                                                         \
     using eval_arg1_t = eval_return_t<EArg1>;                                           \
     using eval_arg2_t = eval_return_t<EArg2>;                                           \
-    using eval_t =                                                                      \
-      decltype(Kokkos::impl(std::declval<eval_arg1_t>(),                                \
-                            std::declval<eval_arg2_t>()));                              \
+    using eval_t = std::common_type_t<eval_arg1_t,eval_arg2_t>;                         \
                                                                                         \
     name##Expression (const EArg1& arg1, const EArg2& arg2)                             \
       : m_arg1(arg1)                                                                    \

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,7 @@ namespace ekat {`
`22`	`22`	`\`
`23`	`23`	`using eval_arg1_t = eval_return_t<EArg1>; \`
`24`	`24`	`using eval_arg2_t = eval_return_t<EArg2>; \`
`25`		`- using eval_t = \`
`26`		`- decltype(Kokkos::impl(std::declval<eval_arg1_t>(), \`
`27`		`- std::declval<eval_arg2_t>())); \`
	`25`	`+ using eval_t = std::common_type_t<eval_arg1_t,eval_arg2_t>; \`
`28`	`26`	`\`
`29`	`27`	`name##Expression (const EArg1& arg1, const EArg2& arg2) \`
`30`	`28`	`: m_arg1(arg1) \`