Skip to content

Commit 85c820e

Browse files
Apply suggestions from code review
1 parent 0d7249e commit 85c820e

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

e3sm_diags/driver/lat_lon_driver.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ def _get_ref_climo_dataset(
446446
"""Get the reference climatology dataset for the variable and season.
447447
448448
If the reference climatatology does not exist or could not be found, it
449-
will be considered a model-only run.
449+
will be considered a model-only run and return `None`.
450450
451451
Parameters
452452
----------
@@ -523,7 +523,6 @@ def _process_test_dataset(
523523
parameter.regrid_method,
524524
)
525525

526-
# Subset on a specific region.
527526
if "global" not in region:
528527
ds_test_region = _subset_on_region(ds_test_region, var_key, region)
529528

e3sm_diags/driver/zonal_mean_xy_driver.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ def run_diag(parameter: CoreParameter) -> CoreParameter:
7272
parameter._set_name_yrs_attrs(test_ds, ref_ds, season)
7373

7474
ds_test = test_ds.get_climo_dataset(var_key, season)
75-
# TODO consider to refactor the behavior of get_climo_dataset
7675
ds_ref = ref_ds.get_climo_dataset(var_key, season)
7776

7877
# Store the variable's DataArray objects for reuse.

0 commit comments

Comments
 (0)