fix pre-commit errors

Author: chengzhuzhang

e3sm_diags/driver/lat_lon_native_driver.py

@@ -259,7 +259,7 @@ def process_variable_derivations(dataset, variable_key, dataset_name=""):  # noq
                     ):
                         data_source = parameter.ref_data_file_path
                     else:
-                        data_source = ds_ref
+                        data_source = ds_ref  # type: ignore
 
                     # Load the dataset with uxarray
                     uxds_ref = ux.open_dataset(grid_file, data_source)
@@ -986,7 +986,7 @@ def _create_metrics_dict(
                 "npe": getattr(uxds, "npe", ""),
                 "element_count": len(uxds.face) if hasattr(uxds, "face") else 0,
             }
-            metrics_dict["grid_info"] = grid_info
+            metrics_dict["grid_info"] = grid_info  # type: ignore
         except Exception as e:
             logger.warning(f"Error adding grid info to metrics: {e}")
 
@@ -1021,7 +1021,7 @@ def _create_metrics_dict(
         # In the first implementation, we'll use global means for simplicity
         metrics_dict["misc"] = {
             "rmse": abs(
-                metrics_dict["test_regrid"]["mean"] - metrics_dict["ref_regrid"]["mean"]
+                metrics_dict["test_regrid"]["mean"] - metrics_dict["ref_regrid"]["mean"]  # type: ignore
             ),
             "corr": 0.0,  # Placeholder - proper correlation would require regridding
         }

e3sm_diags/parameter/lat_lon_native_parameter.py

@@ -18,15 +18,19 @@ def __init__(self):
 
         # Path to the grid files for the native grids
         self.test_grid_file = ""  # Grid file for test data
-        self.ref_grid_file = ""   # Grid file for reference data
+        self.ref_grid_file = ""  # Grid file for reference data
+
+        # File paths for data files (set dynamically during processing)
+        self.test_data_file_path = ""  # Path to test data file
+        self.ref_data_file_path = ""  # Path to reference data file
 
         # Option for handling periodic elements
         # If True, split elements that cross the dateline for better visualization
         self.split_periodic_elements = True
 
         # Style options for native grid visualization
         self.edge_color = None  # Set to a color string to show grid edges
-        self.edge_width = 0.3   # Width of grid edges when displayed
+        self.edge_width = 0.3  # Width of grid edges when displayed
 
         # Option to disable the grid antialiasing (may improve performance)
         self.antialiased = False

e3sm_diags/plot/lat_lon_native_plot.py

@@ -91,9 +91,9 @@ def plot(  # noqa: C901
     region_specs = REGION_SPECS.get(region, None)
 
     # Set map bounds based on region
-    if region_specs:
-        lat_bounds = region_specs.get("lat", (-90, 90))
-        lon_bounds = region_specs.get("lon", (0, 360))
+    if region_specs is not None:
+        lat_bounds = region_specs.get("lat", (-90, 90))  # type: ignore
+        lon_bounds = region_specs.get("lon", (0, 360))  # type: ignore
         is_global_domain = lat_bounds == (-90, 90) and lon_bounds == (0, 360)
     else:
         lat_bounds = (-90, 90)
@@ -138,7 +138,7 @@ def plot(  # noqa: C901
 
     # Extract metrics for reference data if available
     ref_min = ref_max = ref_mean = diff_min = diff_max = diff_mean = None
-    if has_reference:
+    if has_reference and uxds_ref is not None:
         if is_global_domain:
             ref_min = uxds_ref[var_key].min().item()
             ref_max = uxds_ref[var_key].max().item()
@@ -274,10 +274,15 @@ def plot(  # noqa: C901
                     )
 
                     # Add RMSE and correlation text
-                    rmse = abs(diff_mean)  # Simplified RMSE
+                    rmse = (
+                        abs(diff_mean) if diff_mean is not None else None
+                    )  # Simplified RMSE
                     corr = 0.0  # Placeholder - proper correlation would require aligned data
 
-                    if rmse < 0.01:
+                    if rmse is None:
+                        logger.error("RMSE calculation failed: diff_mean is None")
+                        return
+                    elif rmse < 0.01:
                         rmse_fmt = "%.2e"
                     else:
                         rmse_fmt = "%.4f"

e3sm_diags/viewer/default_viewer.py

@@ -176,8 +176,11 @@ def create_viewer(root_dir, parameters):
                         ] = os.path.join(
                             "..", "{}".format(set_name), parameter.case_id, fnm
                         )
-                        print(os.path.join(
-                            "..", "{}".format(set_name), parameter.case_id, fnm))
+                        print(
+                            os.path.join(
+                                "..", "{}".format(set_name), parameter.case_id, fnm
+                            )
+                        )
                         ROW_INFO[set_name][parameter.case_id][row_name][season][
                             "metadata"
                         ] = create_metadata(parameter)