Skip to content

Conversation

@andrewdnolan
Copy link
Collaborator

@andrewdnolan andrewdnolan commented Nov 12, 2025

Bumps mosaic version to 1.2.1, which includes a fix to E3SM-Project/mosaic/#44.

Planar periodic mirroring was added to mosaic in version 1.2.0 and the norm issue for constant fields (E3SM-Project/mosaic/#45) has been fixed as of v1.2.1. So, we now use the "tight" axis limits set by mosaic for planar periodic meshes.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@andrewdnolan
Copy link
Collaborator Author

Testing

Here's what the baroclinic channel looks like with the tight axis limits:
final_normalVelocity

Whereas before this PR, it would have looked like:
final_normalVelocity

@xylar xylar requested a review from cbegeman November 12, 2025 18:52
@xylar
Copy link
Collaborator

xylar commented Nov 12, 2025

@cbegeman, are you able to review this? I think you had stronger opinions than I did on these particular plots.

@xylar xylar added clean-up dependencies Pull requests that update a dependency file framework Changes relating to the polaris framework as opposed to individual tests or analysis labels Nov 12, 2025
@cbegeman
Copy link
Collaborator

Sure, I'll review.

@andrewdnolan Have you tested this for any case that are planar but non-periodic? As long as that looks like our "old" plot, then I'm happy with this change.

@andrewdnolan
Copy link
Collaborator Author

@cbegeman Good idea!

Here's the output for barotropic gyre (run at 10 km resolution).

This PR:
forcing_wind_stress_zonal

Head of main:
forcing_wind_stress_zonal

It's not the easiest to see the boundaries, but they seem just about the same to me. If you have idea of other tasks that are planar (non-periodic) but that can run at coarser resolution, please let me know.

@cbegeman
Copy link
Collaborator

If you have time to rebase onto #353, that would give you a test case with non-periodic boundaries at very coarse resolution

@andrewdnolan
Copy link
Collaborator Author

Testing (Cont.)

Hmm, seems like the barotropic gyre is periodic in the y-dimension. But we can still take a look at the plots:

This PR:
circulation_t-1_zbot
velocity_meridional_t-1_zbot

Prior to this PR:
circulation_t-1_zbot
velocity_meridional_t-1_zbot

Unrelated to this PR, but I'd like to confirm the vertex patches are being properly handled along the boundary here...

@cbegeman
Copy link
Collaborator

Hmm, seems like the barotropic gyre is periodic in the y-dimension.

Yes, sorry, should have mentioned that.

The non-periodic boundary looks good though! Thanks for taking the time to run this case.

Unrelated to this PR, but I'd like to confirm the vertex patches are being properly handled along the boundary here...

That would be fantastic.

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andrewdnolan!

@xylar
Copy link
Collaborator

xylar commented Nov 13, 2025

@andrewdnolan, I set you as the assignee so feel free to merge when you're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-up dependencies Pull requests that update a dependency file framework Changes relating to the polaris framework as opposed to individual tests or analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants