-
Notifications
You must be signed in to change notification settings - Fork 19
Bump mosaic version and tighten planar periodic axis limits
#400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump mosaic version and tighten planar periodic axis limits
#400
Conversation
|
@cbegeman, are you able to review this? I think you had stronger opinions than I did on these particular plots. |
|
Sure, I'll review. @andrewdnolan Have you tested this for any case that are planar but non-periodic? As long as that looks like our "old" plot, then I'm happy with this change. |
|
@cbegeman Good idea! Here's the output for barotropic gyre (run at 10 km resolution). It's not the easiest to see the boundaries, but they seem just about the same to me. If you have idea of other tasks that are planar (non-periodic) but that can run at coarser resolution, please let me know. |
|
If you have time to rebase onto #353, that would give you a test case with non-periodic boundaries at very coarse resolution |
Yes, sorry, should have mentioned that. The non-periodic boundary looks good though! Thanks for taking the time to run this case.
That would be fantastic. |
cbegeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @andrewdnolan!
|
@andrewdnolan, I set you as the assignee so feel free to merge when you're ready. |








Bumps
mosaicversion to1.2.1, which includes a fix to E3SM-Project/mosaic/#44.Planar periodic mirroring was added to
mosaicin version1.2.0and the norm issue for constant fields (E3SM-Project/mosaic/#45) has been fixed as ofv1.2.1. So, we now use the "tight" axis limits set bymosaicfor planar periodic meshes.Checklist
Testingcomment in the PR documents testing used to verify the changes