By default, detect ocean model based on files in path #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `polaris setup` or `polaris suite` without the `--model` flag, the default behavior will now be to look for a list of required files in the component's path (providied with the `-p` flag) to see which model is detecte. If no model can be detected in this way, an error is raised.
This merge makes a copy of the basic_config rather than recreating it, and configures the component only after overriding the default component_path if one is provided on the command line.
Collaborator
Author
TestingI set up both the I'm waiting in the queue on Chrysalis to run these tests but verified that the symlinks to the model executables look right and that message about which model was detected also looked as expected. |
Collaborator
Author
cbegeman
reviewed
Nov 12, 2025
cbegeman
approved these changes
Nov 12, 2025
Collaborator
cbegeman
left a comment
cbegeman
left a comment
There was a problem hiding this comment.
From a brief look, this looks like exactly what we want! One small suggestion on the error message. Thanks for getting this done!
Collaborator
Author
|
@cbegeman, thanks so much for reviewing so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
polaris setuporpolaris suitewithout the--modelflag, the default behavior will now be to look fora list of required files in the component's path (provided with the
-pflag) to see which model is detected. If no model can be detected in this way, an error is raised.This PR also improves config options during setup. This merge makes a copy of the basic_config rather than recreating it, and configures the component only after overriding the default component_path if one is provided on the command line.
Checklist
Testingcomment in the PR documents testing used to verify the changesAddresses #389