Allow ADIOS files to be reopened in write mode in certain cases

Reopening files to append data is not supported by the ADIOS type.
However, users might reopen an existing file in write mode without
performing any actual write operations. In such cases, reopening
an ADIOS file in write mode is acceptable.

An error should only be returned when an actual append operation
is attempted on a reopened ADIOS file.

Author: dqwu

src/clib/pio_darray.cpp

@@ -2169,6 +2169,27 @@ int PIOc_write_darray_impl(int ncid, int varid, int ioid, PIO_Offset arraylen, c
                         "Writing variable (%s, varid=%d) to file (%s, ncid=%d) failed. The file was not opened for writing, try reopening the file in write mode (use the PIO_WRITE flag)", pio_get_vname_from_file(file, varid), varid, pio_get_fname_from_file(file), file->pio_ncid);
     }
 
+    if ((file->iotype == PIO_IOTYPE_ADIOS) || (file->iotype == PIO_IOTYPE_ADIOSC))
+    {
+        /* ADIOS type does not support open to append mode */
+        if (file->is_reopened)
+        {
+            GPTLstop("PIO:PIOc_write_darray");
+            GPTLstop("PIO:write_total");
+            GPTLstop("PIO:PIOc_write_darray_adios");
+            GPTLstop("PIO:write_total_adios");
+            spio_ltimer_stop(ios->io_fstats->wr_timer_name);
+            spio_ltimer_stop(ios->io_fstats->tot_timer_name);
+            spio_ltimer_stop(file->io_fstats->wr_timer_name);
+            spio_ltimer_stop(file->io_fstats->tot_timer_name);
+            return pio_err(ios, file, PIO_EADIOS2ERR, __FILE__, __LINE__,
+                           "Writing variable (%s, varid=%d) to file (%s, ncid=%d) using ADIOS iotype failed. "
+                           "Open to append mode is not supported yet",
+                           pio_get_vname_from_file(file, varid), varid,
+                           pio_get_fname_from_file(file), ncid);
+        }
+    }
+
     /* Get decomposition information. */
     if (!(iodesc = pio_get_iodesc_from_id(ioid)))
     {

src/clib/pio_getput_int.cpp

@@ -62,6 +62,22 @@ int spio_put_att_tc(int ncid, int varid, const char *name, nc_type atttype,
 
     if ((file->iotype == PIO_IOTYPE_ADIOS) || (file->iotype == PIO_IOTYPE_ADIOSC))
     {
+        /* ADIOS type does not support open to append mode */
+        if (file->is_reopened)
+        {
+            GPTLstop("PIO:spio_put_att_tc");
+            GPTLstop("PIO:write_total");
+            spio_ltimer_stop(ios->io_fstats->wr_timer_name);
+            spio_ltimer_stop(ios->io_fstats->tot_timer_name);
+            spio_ltimer_stop(file->io_fstats->wr_timer_name);
+            spio_ltimer_stop(file->io_fstats->tot_timer_name);
+            return pio_err(ios, file, PIO_EADIOS2ERR, __FILE__, __LINE__,
+                           "Writing variable (%s, varid=%d) attribute (%s) to file (%s, ncid=%d) using ADIOS iotype failed. "
+                           "Open to append mode is not supported yet",
+                           pio_get_vname_from_file(file, varid), varid, PIO_IS_NULL(name),
+                           pio_get_fname_from_file(file), ncid);
+        }
+
         GPTLstart("PIO:spio_put_att_tc_adios");
         GPTLstart("PIO:write_total_adios");
     }
@@ -2465,6 +2481,22 @@ int spio_put_vars_tc(int ncid, int varid, const PIO_Offset *start, const PIO_Off
 
     if ((file->iotype == PIO_IOTYPE_ADIOS) || (file->iotype == PIO_IOTYPE_ADIOSC))
     {
+        /* ADIOS type does not support open to append mode */
+        if (file->is_reopened)
+        {
+            GPTLstop("PIO:spio_put_vars_tc");
+            GPTLstop("PIO:write_total");
+            spio_ltimer_stop(ios->io_fstats->wr_timer_name);
+            spio_ltimer_stop(ios->io_fstats->tot_timer_name);
+            spio_ltimer_stop(file->io_fstats->wr_timer_name);
+            spio_ltimer_stop(file->io_fstats->tot_timer_name);
+            return pio_err(ios, file, PIO_EADIOS2ERR, __FILE__, __LINE__,
+                           "Writing variable (%s, varid=%d) to file (%s, ncid=%d) using ADIOS iotype failed. "
+                           "Open to append mode is not supported yet",
+                           pio_get_vname_from_file(file, varid), varid,
+                           pio_get_fname_from_file(file), ncid);
+        }
+
         GPTLstart("PIO:spio_put_vars_tc_adios");
         GPTLstart("PIO:write_total_adios");
     }

src/clib/pioc_support.cpp

@@ -4727,18 +4727,6 @@ int PIOc_openfile_retry_impl(int iosysid, int *ncidp, int *iotype, const char *f
 #ifdef _ADIOS2
     if ((file->iotype == PIO_IOTYPE_ADIOS) || (file->iotype == PIO_IOTYPE_ADIOSC))
     {
-        if (mode & PIO_WRITE)
-        {
-            spio_ltimer_stop(ios->io_fstats->rd_timer_name);
-            spio_ltimer_stop(ios->io_fstats->tot_timer_name);
-            spio_ltimer_stop(file->io_fstats->rd_timer_name);
-            spio_ltimer_stop(file->io_fstats->tot_timer_name);
-            return pio_err(ios, NULL, PIO_EADIOS2ERR, __FILE__, __LINE__,
-                           "Opening file (%s) using ADIOS iotype failed. "
-                           "Open to append mode is not supported yet",
-                           filename);
-        }
-
         /* Trying to open a file with adios unless ADIOS_BP2NC_TEST option is enabled for unit tests */
         bool adios2_file_exist = false;