-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Labels
Description
This error code checking is problematic. Assuming it is possible that ierr can
be different among processes, checking only root's ierr at line 1429 after bcast
at line 1422 may not detect a failure on other processes.
Lines 1421 to 1434 in ac679a5
| /* A failure to inquire is not fatal */ | |
| mpierr = MPI_Bcast(&ierr, 1, MPI_INT, ios->ioroot, ios->my_comm); | |
| if(mpierr != MPI_SUCCESS){ | |
| spio_ltimer_stop(ios->io_fstats->tot_timer_name); | |
| spio_ltimer_stop(file->io_fstats->tot_timer_name); | |
| return check_mpi(NULL, file, mpierr, __FILE__, __LINE__); | |
| } | |
| if(ierr != PIO_NOERR){ | |
| LOG((1, "nc*_inq_var failed, ierr = %d", ierr)); | |
| spio_ltimer_stop(ios->io_fstats->tot_timer_name); | |
| spio_ltimer_stop(file->io_fstats->tot_timer_name); | |
| return ierr; | |
| } |