Skip to content

Commit f7cb09e

Browse files
committed
Test fixes
- Make legacy 3.1.0 references consistent with 3.0.0 - Always run land_monthly subtask, as it's needed by e3sm_diags AND ilamb
1 parent 2b27537 commit f7cb09e

12 files changed

+85
-40
lines changed

tests/integration/generated/test_weekly_bundles_chrysalis.cfg

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ years = "1985:1989:2",
7979
years = "1985:1995:5",
8080

8181
[[ land_monthly ]]
82-
active = True
8382
extra_vars = "landfrac"
8483
frequency = "monthly"
8584
input_files = "elm.h0"

tests/integration/generated/test_weekly_legacy_3.1.0_bundles_chrysalis.cfg

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ input = /lcrc/group/e3sm2/ac.wlin//E3SMv3/v3.LR.historical_0051
3232
input_subdir = archive/atm/hist
3333
mapping_file = "map_ne30pg2_to_cmip6_180x360_aave.20200201.nc"
3434
# To run this test, edit `output` and `www` in this file, along with `actual_images_dir` in test_bundles.py
35-
output = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_bundles_output/unique_id/v3.LR.historical_0051"
35+
output = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_bundles_output/unique_id/v3.LR.historical_0051"
3636
partition = "compute"
3737
qos = "regular"
3838
walltime = "07:00:00"
@@ -79,7 +79,6 @@ years = "1985:1989:2",
7979
years = "1985:1995:5",
8080

8181
[[ land_monthly ]]
82-
active = True
8382
extra_vars = "landfrac"
8483
frequency = "monthly"
8584
input_files = "elm.h0"
@@ -141,7 +140,7 @@ years = "1985:1989:2",
141140
ref_name = "v3.LR.historical_0051"
142141
ref_start_yr = 1985
143142
ref_years = "1985-1986",
144-
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_bundles_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/clim"
143+
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_bundles_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/clim"
145144
run_type = "model_vs_model"
146145
# TODO: Add "tc_analysis" back in after empty dat is resolved.
147146
sets = "polar","enso_diags","streamflow",

tests/integration/generated/test_weekly_legacy_3.1.0_comprehensive_v2_chrysalis.cfg

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ fail_on_dependency_skip = True
77
input = /lcrc/group/e3sm/ac.forsyth2//E3SMv2/v2.LR.historical_0201
88
input_subdir = archive/atm/hist
99
mapping_file = "map_ne30pg2_to_cmip6_180x360_aave.20200201.nc"
10-
output = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v2_output/unique_id/v2.LR.historical_0201"
10+
output = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v2_output/unique_id/v2.LR.historical_0201"
1111
partition = "debug"
1212
qos = "regular"
1313
www = "/lcrc/group/e3sm/public_html/diagnostic_output/ac.forsyth2/zppy_weekly_comprehensive_v2_www/unique_id"
@@ -140,7 +140,7 @@ years = "1982:1984:2",
140140
partition = "compute"
141141
qos = "regular"
142142
ref_name = "v2.LR.historical_0201"
143-
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v2_output/unique_id/v2.LR.historical_0201/post/atm/180x360_aave/clim"
143+
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v2_output/unique_id/v2.LR.historical_0201/post/atm/180x360_aave/clim"
144144
run_type = "model_vs_model"
145145
short_ref_name = "same simulation"
146146
swap_test_ref = False
@@ -157,7 +157,7 @@ years = "1982:1984:2",
157157
partition = "compute"
158158
qos = "regular"
159159
ref_name = "v2.LR.historical_0201"
160-
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v2_output/unique_id/v2.LR.historical_0201/post/lnd/180x360_aave/clim"
160+
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v2_output/unique_id/v2.LR.historical_0201/post/lnd/180x360_aave/clim"
161161
run_type = "model_vs_model"
162162
sets = "lat_lon_land",
163163
short_ref_name = "same simulation"

tests/integration/generated/test_weekly_legacy_3.1.0_comprehensive_v3_chrysalis.cfg

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ infer_section_parameters = False
99
input = /lcrc/group/e3sm2/ac.wlin//E3SMv3/v3.LR.historical_0051
1010
input_subdir = archive/atm/hist
1111
mapping_file = "map_ne30pg2_to_cmip6_180x360_aave.20200201.nc"
12-
output = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/unique_id/v3.LR.historical_0051"
12+
output = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v3_output/unique_id/v3.LR.historical_0051"
1313
partition = "debug"
1414
qos = "regular"
1515
www = "/lcrc/group/e3sm/public_html/diagnostic_output/ac.forsyth2/zppy_weekly_comprehensive_v3_www/unique_id"
@@ -171,16 +171,16 @@ tc_obs = "/lcrc/group/e3sm/diagnostics/observations/Atm/tc-analysis/"
171171
tag = "model_vs_model"
172172
ts_num_years_ref = 2
173173
# Reference paths
174-
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/clim"
174+
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/clim"
175175
# mvm streamflow only
176176
gauges_path = "/lcrc/group/e3sm/diagnostics/observations/Atm/time-series/GSIM/GSIM_catchment_characteristics_all_1km2.csv"
177-
reference_data_path_ts_rof = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/rof/native/ts/monthly"
177+
reference_data_path_ts_rof = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/rof/native/ts/monthly"
178178
# mvm diurnal_cycle only
179-
reference_data_path_climo_diurnal = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/clim_diurnal_8xdaily"
179+
reference_data_path_climo_diurnal = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/clim_diurnal_8xdaily"
180180
# mvm "enso_diags", "qbo", "area_mean_time_series"
181-
reference_data_path_ts = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/ts/monthly"
181+
reference_data_path_ts = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/ts/monthly"
182182
# mvm tropical_subseasonal only
183-
reference_data_path_ts_daily = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/ts/daily"
183+
reference_data_path_ts_daily = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/atm/180x360_aave/ts/daily"
184184

185185
[[ lnd_monthly_mvm_lnd ]]
186186
# Test model-vs-model using the same files as the reference
@@ -196,7 +196,7 @@ tc_obs = "/lcrc/group/e3sm/diagnostics/observations/Atm/tc-analysis/"
196196
tag = "model_vs_model"
197197
ts_num_years_ref = 2
198198
# Reference paths
199-
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/lnd/180x360_aave/clim"
199+
reference_data_path = "/lcrc/group/e3sm/ac.forsyth2/zppy_weekly_legacy_3.1.0_comprehensive_v3_output/unique_id/v3.LR.historical_0051/post/lnd/180x360_aave/clim"
200200

201201
[mpas_analysis]
202202
active = True

tests/integration/generated/update_weekly_expected_files_chrysalis.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,15 @@
66
# NOTE: in `tests` below, do *not* include the `zppy_weekly_` prefix, as that is added later.
77

88
# Update all
9-
tests=("comprehensive_v2" "comprehensive_v3" "bundles" "legacy_3.0.0_comprehensive_v2" "legacy_3.0.0_comprehensive_v3" "legacy_3.0.0_bundles")
9+
tests=("comprehensive_v2" "comprehensive_v3" "bundles" "legacy_3.1.0_comprehensive_v2" "legacy_3.1.0_comprehensive_v3" "legacy_3.1.0_bundles" "legacy_3.0.0_comprehensive_v2" "legacy_3.0.0_comprehensive_v3" "legacy_3.0.0_bundles")
1010

1111
# Update regular only
1212
#tests=("comprehensive_v2" "comprehensive_v3" "bundles")
1313

14-
# Update legacy only
14+
# Update legacy 3.1.0 only
15+
#tests=("legacy_3.1.0_comprehensive_v2" "legacy_3.1.0_comprehensive_v3" "legacy_3.1.0_bundles")
16+
17+
# Update legacy 3.0.0 only
1518
#tests=("legacy_3.0.0_comprehensive_v2" "legacy_3.0.0_comprehensive_v3" "legacy_3.0.0_bundles")
1619

1720
for test_name in "${tests[@]}"
@@ -20,9 +23,10 @@ do
2023
#
2124
# expected_dir = /lcrc/group/e3sm/public_html/zppy_test_resources/
2225
#
23-
# There are 6 subdirectories relevant to image checking:
26+
# There are 9 subdirectories relevant to image checking:
2427
# 1-3. expected_bundles, expected_comprehensive_v2, expected_comprehensive_v3
25-
# 4-6. expected_legacy_3.0.0_bundles, expected_legacy_3.0.0_comprehensive_v2, expected_legacy_3.0.0_comprehensive_v3
28+
# 4-6. expected_legacy_3.1.0_bundles, expected_legacy_3.1.0_comprehensive_v2, expected_legacy_3.1.0_comprehensive_v3
29+
# 7-9. expected_legacy_3.0.0_bundles, expected_legacy_3.0.0_comprehensive_v2, expected_legacy_3.0.0_comprehensive_v3
2630
# Notice the subdirectories do *not* include the `zppy_weekly` prefix.
2731
#
2832
# Each of those subdirectories has a corresponding image list of the form:

tests/integration/template_update_weekly_expected_files.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,15 @@
66
# NOTE: in `tests` below, do *not* include the `zppy_weekly_` prefix, as that is added later.
77

88
# Update all
9-
tests=("comprehensive_v2" "comprehensive_v3" "bundles" "legacy_3.0.0_comprehensive_v2" "legacy_3.0.0_comprehensive_v3" "legacy_3.0.0_bundles")
9+
tests=("comprehensive_v2" "comprehensive_v3" "bundles" "legacy_3.1.0_comprehensive_v2" "legacy_3.1.0_comprehensive_v3" "legacy_3.1.0_bundles" "legacy_3.0.0_comprehensive_v2" "legacy_3.0.0_comprehensive_v3" "legacy_3.0.0_bundles")
1010

1111
# Update regular only
1212
#tests=("comprehensive_v2" "comprehensive_v3" "bundles")
1313

14-
# Update legacy only
14+
# Update legacy 3.1.0 only
15+
#tests=("legacy_3.1.0_comprehensive_v2" "legacy_3.1.0_comprehensive_v3" "legacy_3.1.0_bundles")
16+
17+
# Update legacy 3.0.0 only
1518
#tests=("legacy_3.0.0_comprehensive_v2" "legacy_3.0.0_comprehensive_v3" "legacy_3.0.0_bundles")
1619

1720
for test_name in "${tests[@]}"
@@ -20,9 +23,10 @@ do
2023
#
2124
# expected_dir = /lcrc/group/e3sm/public_html/zppy_test_resources/
2225
#
23-
# There are 6 subdirectories relevant to image checking:
26+
# There are 9 subdirectories relevant to image checking:
2427
# 1-3. expected_bundles, expected_comprehensive_v2, expected_comprehensive_v3
25-
# 4-6. expected_legacy_3.0.0_bundles, expected_legacy_3.0.0_comprehensive_v2, expected_legacy_3.0.0_comprehensive_v3
28+
# 4-6. expected_legacy_3.1.0_bundles, expected_legacy_3.1.0_comprehensive_v2, expected_legacy_3.1.0_comprehensive_v3
29+
# 7-9. expected_legacy_3.0.0_bundles, expected_legacy_3.0.0_comprehensive_v2, expected_legacy_3.0.0_comprehensive_v3
2630
# Notice the subdirectories do *not* include the `zppy_weekly` prefix.
2731
#
2832
# Each of those subdirectories has a corresponding image list of the form:

tests/integration/template_weekly_bundles.cfg

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ years = "1985:1989:2",
7979
years = "1985:1995:5",
8080

8181
[[ land_monthly ]]
82-
active = #expand active_e3sm_diags#
8382
extra_vars = "landfrac"
8483
frequency = "monthly"
8584
input_files = "elm.h0"

tests/integration/template_weekly_legacy_3.0.0_bundles.cfg

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ years = "1985:1989:2",
7979
years = "1985:1995:5",
8080

8181
[[ land_monthly ]]
82-
active = #expand active_e3sm_diags#
8382
extra_vars = "landfrac"
8483
frequency = "monthly"
8584
input_files = "elm.h0"

tests/integration/template_weekly_legacy_3.1.0_bundles.cfg

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ input = #expand user_input_v3#/E3SMv3/#expand case_name#
3232
input_subdir = archive/atm/hist
3333
mapping_file = "map_ne30pg2_to_cmip6_180x360_aave.20200201.nc"
3434
# To run this test, edit `output` and `www` in this file, along with `actual_images_dir` in test_bundles.py
35-
output = "#expand user_output#zppy_weekly_bundles_output/#expand unique_id#/#expand case_name#"
35+
output = "#expand user_output#zppy_weekly_legacy_3.1.0_bundles_output/#expand unique_id#/#expand case_name#"
3636
partition = "#expand partition_long#"
3737
qos = "#expand qos_short#"
3838
walltime = "#expand bundles_walltime#"
@@ -79,7 +79,6 @@ years = "1985:1989:2",
7979
years = "1985:1995:5",
8080

8181
[[ land_monthly ]]
82-
active = #expand active_e3sm_diags#
8382
extra_vars = "landfrac"
8483
frequency = "monthly"
8584
input_files = "elm.h0"
@@ -141,7 +140,7 @@ years = "1985:1989:2",
141140
ref_name = "#expand case_name#"
142141
ref_start_yr = 1985
143142
ref_years = "1985-1986",
144-
reference_data_path = "#expand user_output#zppy_weekly_bundles_output/#expand unique_id#/#expand case_name#/post/atm/180x360_aave/clim"
143+
reference_data_path = "#expand user_output#zppy_weekly_legacy_3.1.0_bundles_output/#expand unique_id#/#expand case_name#/post/atm/180x360_aave/clim"
145144
run_type = "model_vs_model"
146145
# TODO: Add "tc_analysis" back in after empty dat is resolved.
147146
sets = "polar","enso_diags","streamflow",

tests/integration/template_weekly_legacy_3.1.0_comprehensive_v2.cfg

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ fail_on_dependency_skip = True
77
input = #expand user_input_v2#/E3SMv2/#expand case_name_v2#
88
input_subdir = archive/atm/hist
99
mapping_file = "map_ne30pg2_to_cmip6_180x360_aave.20200201.nc"
10-
output = "#expand user_output#zppy_weekly_comprehensive_v2_output/#expand unique_id#/#expand case_name_v2#"
10+
output = "#expand user_output#zppy_weekly_legacy_3.1.0_comprehensive_v2_output/#expand unique_id#/#expand case_name_v2#"
1111
partition = "#expand partition_short#"
1212
qos = "#expand qos_short#"
1313
www = "#expand user_www#zppy_weekly_comprehensive_v2_www/#expand unique_id#"
@@ -140,7 +140,7 @@ years = "1982:1984:2",
140140
partition = "#expand partition_long#"
141141
qos = "#expand qos_long#"
142142
ref_name = "#expand case_name_v2#"
143-
reference_data_path = "#expand user_output#zppy_weekly_comprehensive_v2_output/#expand unique_id#/#expand case_name_v2#/post/atm/180x360_aave/clim"
143+
reference_data_path = "#expand user_output#zppy_weekly_legacy_3.1.0_comprehensive_v2_output/#expand unique_id#/#expand case_name_v2#/post/atm/180x360_aave/clim"
144144
run_type = "model_vs_model"
145145
short_ref_name = "same simulation"
146146
swap_test_ref = False
@@ -157,7 +157,7 @@ years = "1982:1984:2",
157157
partition = "#expand partition_long#"
158158
qos = "#expand qos_long#"
159159
ref_name = "#expand case_name_v2#"
160-
reference_data_path = "#expand user_output#zppy_weekly_comprehensive_v2_output/#expand unique_id#/#expand case_name_v2#/post/lnd/180x360_aave/clim"
160+
reference_data_path = "#expand user_output#zppy_weekly_legacy_3.1.0_comprehensive_v2_output/#expand unique_id#/#expand case_name_v2#/post/lnd/180x360_aave/clim"
161161
run_type = "model_vs_model"
162162
sets = "lat_lon_land",
163163
short_ref_name = "same simulation"

0 commit comments

Comments
 (0)