Skip to content

List paths in generated diags py file #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

List paths in generated diags py file #674

wants to merge 1 commit into from

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Feb 4, 2025

Summary

Objectives:

  • Allow users to see original data paths in the diags python file, rather than looking at the bash file.

Issue resolution:

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Feb 4, 2025
forsyth2
forsyth2 commented Feb 4, 2025
View reviewed changes
Copy link
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengzhuzhang I haven't actually run this, but would something like this help/solve #670, in particular your note at #651 (comment)?

zppy/templates/e3sm_diags.bash
Comment on lines +158 to +166
# Path information:
# For climo, data is copied from these directories to a local directory
# climo_dir_source_lnd_obs = ${climo_dir_source_lnd_obs}
# climo_dir_source_lnd_ref = ${climo_dir_source_lnd_ref}
# climo_dir_source_atm_obs = ${climo_dir_source_atm_obs}
# climo_dir_source_atm_ref = ${climo_dir_source_atm_ref}
# climo_diurnal_dir_source_obs = ${climo_diurnal_dir_source_obs}
# climo_diurnal_dir_source_ref = ${climo_diurnal_dir_source_ref}
# For ts, data is used directly from original directories
Copy link
Collaborator Author

@forsyth2 forsyth2 Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in bash an undefined variable will just show up as an empty string, so this shouldn't cause problems

@forsyth2 forsyth2 added the semver: small improvement Small improvement (will increment patch version) label Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@forsyth2 forsyth2

Labels

semver: small improvement Small improvement (will increment patch version)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reproducibility of e3sm_diags runs from zppy

2 participants

@forsyth2