fix const correctness and bugprone-exception-escape issues

Author: lucafedeli88

multi_physics/QED/include/picsar_qed/physics/quantum_sync/quantum_sync_engine_tabulated_functions.hpp

@@ -67,7 +67,7 @@ namespace picsar::multi_physics::phys::quantum_sync
     * @return the integral of kv(5/3, x) from y to infinity
     */
     template<typename RealType>
-    inline RealType inner_integral(const RealType y)
+    RealType inner_integral(const RealType y)
     {
         using namespace math;
         return quad_a_inf<RealType>(
@@ -105,7 +105,7 @@ namespace picsar::multi_physics::phys::quantum_sync
     * @return the value of the integrand of the G function
     */
     template<typename RealType>
-    inline RealType compute_G_integrand(
+    RealType compute_G_integrand(
         const RealType chi_part, const RealType csi) noexcept
     {
         using namespace math;
@@ -142,7 +142,7 @@ namespace picsar::multi_physics::phys::quantum_sync
     * @return the value of the G function
     */
     template<typename RealType>
-    inline RealType compute_G_function(const RealType chi_part)
+    RealType compute_G_function(const RealType chi_part)
     {
         using namespace math;
         return quad_a_b_s<RealType>(
@@ -166,7 +166,7 @@ namespace picsar::multi_physics::phys::quantum_sync
     * @return the value of the numerator of the cumulative probability distribution
     */
     template<typename RealType>
-    inline RealType compute_cumulative_prob_numerator_a_b(
+    RealType compute_cumulative_prob_numerator_a_b(
         const RealType chi_particle,
         RealType chi_photon_start,
         RealType chi_photon_end)
@@ -215,7 +215,7 @@ namespace picsar::multi_physics::phys::quantum_sync
     * @return the value of the numerator of the cumulative probability distribution
     */
     template<typename RealType>
-    inline RealType compute_cumulative_prob_numerator(
+    RealType compute_cumulative_prob_numerator(
         const RealType chi_particle, RealType chi_photon)
     {
         using namespace math;
@@ -236,7 +236,7 @@ namespace picsar::multi_physics::phys::quantum_sync
     * @return the cumulative probability distribution calculated for all the chi parameters
     */
     template<typename RealType, typename VectorType>
-    inline VectorType compute_cumulative_prob(
+    VectorType compute_cumulative_prob(
         const RealType chi_particle, const VectorType& chi_photons)
     {
         const auto den = compute_G_function(chi_particle);
@@ -271,7 +271,7 @@ namespace picsar::multi_physics::phys::quantum_sync
     * @return the cumulative probability distribution calculated for all the chi parameters
     */
     template<typename RealType, typename VectorType>
-    inline VectorType compute_cumulative_prob_opt(
+    VectorType compute_cumulative_prob_opt(
         const RealType chi_particle, const VectorType& chi_photons)
     {
         if(!std::is_sorted(chi_photons.begin(), chi_photons.end())){

multi_physics/QED/kokkos_example/kokkos_example_quantum_synchrotron.cpp

@@ -37,7 +37,8 @@ auto generate_dndt_table(const Real chi_min, const Real chi_max, const int chi_s
         << ", " << chi_size <<"]...\n";
     std::cout.flush();
 
-    pxr_qs::dndt_lookup_table_params<Real> qs_params{chi_min, chi_max, chi_size};
+    const auto qs_params =
+        pxr_qs::dndt_lookup_table_params<Real>{chi_min, chi_max, chi_size};
 
 	auto table = pxr_qs::dndt_lookup_table<
         Real, Vector>{qs_params};