Remove FactoryBot line that was initiating db connection on app startup

Was preventing us from creating a database with bin/rails db:create
because it tried to connect to that same database before it was able
to be created.

Author: hartsick

Diff for: .env.example

@@ -9,7 +9,6 @@ force_ssl=false
 time_zone="Pacific Time (US & Canada)"
 
 # Database configuration (required)
-db_database=postgres
 db_username=postgres
 db_password=mysecretpassword
 db_port=5432

Diff for: .github/workflows/rails_ci.yml

@@ -6,10 +6,6 @@
 # run tests and linters.
 name: "Ruby on Rails CI"
 on: push
-  # push:
-  #   branches: [ $default-branch, 2024-upgrades-main ]
-  # pull_request:
-  #   branches: [ $default-branch, 2024-upgrades-main ]
 jobs:
   test:
     runs-on: ubuntu-latest
@@ -26,7 +22,6 @@ jobs:
         ports:
           - "5432:5432"
         env:
-          POSTGRES_DB: actioncenter_test # must be same as in database.yml for test.database
           POSTGRES_USER: testuser
           POSTGRES_PASSWORD: password
         options: >-

Diff for: config/database.yml

@@ -11,15 +11,15 @@ common: &common
 
 development:
   <<: *common
-  database: <%= Rails.application.secrets.db_database || "actioncenter_development" %>
+  database: act_development
 
 production:
   <<: *common
   database: <%= Rails.application.secrets.db_database %>
 
 test: &test
   <<: *common
-  database: actioncenter_test
+  database: act_test
 
 cucumber:
   <<: *test

Diff for: spec/factories/users.rb

@@ -2,7 +2,7 @@
 
 FactoryBot.define do
   factory :unconfirmed_user, class: User do
-    sequence(:email, ActiveRecord::Base.connection.table_exists?("users") ? User.next_id : 0) { |n| "person_#{n}@example.com" }
+    sequence(:email) { |n| "person_#{n}@example.com" }
     password { "strong passwords defeat lobsters covering wealth" }
   end