Merge pull request #940 from EFForg/system-test-edits

System tests user signin improvements

Author: esoterik

spec/features/congress_message.rb

@@ -46,12 +46,18 @@
 Capybara.disable_animation = true
 
 RSpec.configure do |config|
+  config.include ServiceHelpers
+
   config.include Devise::Test::ControllerHelpers, type: :controller
-  config.include Devise::Test::IntegrationHelpers, type: :system
+
   config.include Devise::Test::IntegrationHelpers, type: :request
   config.include Warden::Test::Helpers, type: :request
+
+  config.include Devise::Test::IntegrationHelpers, type: :system
   config.include Warden::Test::Helpers, type: :system
 
+  config.include JavascriptHelpers, type: :system, js: true
+
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
   config.fixture_path = Rails.root.join("spec/fixtures")
 
@@ -84,10 +90,12 @@
   end
 
   config.before(:each, type: :system) do
+    stub_civicrm
     driven_by :rack_test
   end
 
   config.before(:each, type: :system, js: true) do
+    stub_civicrm
     driven_by :selenium_chrome_headless
   end
 

spec/rails_helper.rb

@@ -33,7 +33,6 @@
   end
 
   config.include Capybara::DSL
-  config.include FeatureHelpers, type: :system
 
   WebMock.disable_net_connect!(allow_localhost: true, allow: "chromedriver.storage.googleapis.com")
 end

spec/spec_helper.rb

@@ -0,0 +1,19 @@
+module JavascriptHelpers
+  def warden_sign_in(user)
+    # this calls a helper from Warden::Test::Helpers
+    login_as(user, scope: :user)
+  end
+
+  def fill_in_editor(locator, with:)
+    within_frame find(locator, visible: :all).sibling("div").find("iframe") do
+      within_frame find("#epiceditor-editor-frame") do
+        find("body").set(with)
+      end
+    end
+  end
+
+  def fill_in_select2(locator, with:)
+    find(locator).sibling(".select2-container").click
+    find("li.select2-results__option[role=treeitem]", text: with).click
+  end
+end

spec/support/feature_helpers.rb

@@ -9,9 +9,3 @@ def stub_civicrm
       .and_return(status: 200, body: { checksum: "xyz" }.to_json, headers: {})
   end
 end
-
-RSpec.configure do |c|
-  c.include ServiceHelpers
-end
-
-World(ServiceHelpers) if respond_to?(:World) # cucumber