Skip to content

Commit bc4f714

Browse files
committed
use range checks in cohort integrity tests
1 parent 01846c0 commit bc4f714

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

tests/test_pipeline_qc.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,18 @@ class TestCohortIntegrity:
2727

2828
def test_training_table_row_count(self):
2929
df = _load_training_table()
30-
assert len(df) == 16963, f"Expected 16963 rows, got {len(df)}"
30+
assert 16800 <= len(df) <= 17200, f"Row count out of expected range: {len(df)}"
3131

3232
def test_split_sizes(self):
3333
df = _load_training_table()
3434
counts = df["temporal_split"].value_counts()
35-
assert counts.get("train", 0) == 13342, f"train: {counts.get('train')}"
36-
assert counts.get("validate", 0) == 1677, f"validate: {counts.get('validate')}"
37-
assert counts.get("test", 0) == 1944, f"test: {counts.get('test')}"
35+
n = len(df)
36+
train_frac = counts.get("train", 0) / n
37+
val_frac = counts.get("validate", 0) / n
38+
test_frac = counts.get("test", 0) / n
39+
assert 0.77 <= train_frac <= 0.81, f"train fraction {train_frac:.3f} out of range"
40+
assert 0.09 <= val_frac <= 0.11, f"validate fraction {val_frac:.3f} out of range"
41+
assert 0.10 <= test_frac <= 0.13, f"test fraction {test_frac:.3f} out of range"
3842

3943
def test_positive_prevalence_test_set(self):
4044
df = _load_training_table()

0 commit comments

Comments
 (0)