Bug/i1631 Row/ColumnOffsets (#1633)

* Fix for #1631 column/row offset in shared formulas

* Added fixed issues note

* add testmethod

Author: OssianEPPlus

docs/articles/fixedissues.md

@@ -1,5 +1,8 @@
 # Features / Fixed issues - EPPlus 7
 
+## Version 7.4.2
+* Fixed innacurate relative addresses in cloned formulas in rare cases.
+
 
 
 * Deleting and adding a table with multiple worksheets no longer gives the added table an invalid id. 

src/EPPlus/FormulaParsing/LexicalAnalysis/FormulaAddress.cs

@@ -206,21 +206,24 @@ public List<Token> TokensWithFullAddresses
 
         internal SharedFormula Clone()
         {
-            return new SharedFormula(_ws, StartRow, StartCol, EndRow, EndCol, Formula)
-            {
-                Index = Index,
-                FormulaType = FormulaType,
-                Tokens = Tokens,
-                RpnTokens = RpnTokens,
-                Address = Address,
-                DataTableIsTwoDimesional = DataTableIsTwoDimesional,
-                IsDataTableRow = IsDataTableRow,
-                R1CellAddress = R1CellAddress,
-                R2CellAddress = R2CellAddress,
-                FirstCellDeleted = FirstCellDeleted,
-                SecondCellDeleted = SecondCellDeleted,
-                _ws = _ws,                
-            };
+            var sh = new SharedFormula(_ws, StartRow, StartCol, EndRow, EndCol, Formula);
+
+            sh.Index = Index;
+            sh.FormulaType = FormulaType;
+            sh.Tokens = null;
+            sh.RpnTokens = null;
+            //sh.Address = Address;
+            sh.StartColOffset = StartColOffset;
+            sh.StartRowOffset = StartRowOffset;
+            //sh.StartCol = StartCol;
+            sh.DataTableIsTwoDimesional = DataTableIsTwoDimesional;
+            sh.IsDataTableRow = IsDataTableRow;
+            sh.R1CellAddress = R1CellAddress;
+            sh.R2CellAddress = R2CellAddress;
+            sh.FirstCellDeleted = FirstCellDeleted;
+            sh.SecondCellDeleted = SecondCellDeleted;
+            sh._ws = _ws;
+            return sh;
         }
         internal Formula GetFormula(int row, int col)
         {

src/EPPlusTest/Issues/CopyIssues.cs

@@ -62,6 +62,27 @@ public void s651_2()
 			}
 		}
         [TestMethod]
+        public void i1623()
+        {
+            using (var p = OpenTemplatePackage("i1623.xlsx"))
+            {
+                using (var p2 = OpenPackage("i1623-clone.xlsx", true))
+                {
+                    var src = p.Workbook.Worksheets.First();
+                    ExcelWorksheet dup = p2.Workbook.Worksheets.Add("dup", src);
+                    for (int col = 1; col < src.Dimension.End.Column; col++)
+                    {
+                        Console.WriteLine($"is equal? :{src.Cells[5, col].FormulaR1C1.Equals(dup.Cells[5, col].FormulaR1C1)},{src.Cells[5, col].FormulaR1C1} => {dup.Cells[5, col].FormulaR1C1}");
+                    }
+                    for (int col = 1; col < src.Dimension.End.Column; col++)
+                    {
+                        Assert.AreEqual(src.Cells[5, col].FormulaR1C1, dup.Cells[5, col].FormulaR1C1);
+                    }
+                    SaveAndCleanup(p2);
+                }
+            }
+        }
+        [TestMethod]
         public void i1645()
         {
             using (var package = OpenTemplatePackage("i1645.xlsx"))