EPPlus version 5.8.3

Author: JanKallman

appveyor.yml

@@ -1,20 +1,20 @@
-version: 5.8.2.{build}
+version: 5.8.3.{build}
 branches:
   only:
   - develop
 configuration: release
 platform: Any CPU
 init:
 - ps: >-
-    Update-AppveyorBuild -Version "5.8.2.$env:appveyor_build_number-$(Get-Date -format yyyyMMdd)-$env:appveyor_repo_branch"
+    Update-AppveyorBuild -Version "5.8.3.$env:appveyor_build_number-$(Get-Date -format yyyyMMdd)-$env:appveyor_repo_branch"
 
-    Write-Host "5.8.2.$env:appveyor_build_number-$(Get-Date -format yyyyMMdd)-$env:appveyor_repo_branch"
+    Write-Host "5.8.3.$env:appveyor_build_number-$(Get-Date -format yyyyMMdd)-$env:appveyor_repo_branch"
 dotnet_csproj:
   patch: true
   file: '**\*.csproj'
   version: '{version}'
-  assembly_version: 5.8.2.{build}
-  file_version: 5.8.2.{build}
+  assembly_version: 5.8.3.{build}
+  file_version: 5.8.3.{build}
 nuget:
   project_feed: true
 before_build:

docs/articles/fixedissues.md

@@ -1,4 +1,13 @@
 # Features / Fixed issues - EPPlus 5
+## Version 5.8.3
+### Fixed issues
+* Inserting rows into a worksheet sometimes didn't update addresses on workbook defined names.
+* Overlapping data validation addresses was validated on save which cause workbooks containing such not to be saved.
+* Failed to copy cells when data validations or conditional formatting was set.
+* COUNTIFS, AVERAGEIFS and SUMIFS fails with single cell ranges.
+* Packages with VBA project with a component reference with encoded characters causes the saved package to become corrupt.
+* It was not possible to specify legend entry properties for items from secondary y-axis.
+
 ## Version 5.8.2
 ### Fixed issues
 * Range.Text returned the wrong value for format #.##0"*";(#.##0)"*" on negative values

src/EPPlus/ExcelAddressBase.cs

@@ -674,7 +674,7 @@ internal string AddressSpaceSeparated
         /// </summary>
         protected void Validate()
         {
-            if (_fromRow > _toRow || _fromCol > _toCol)
+            if ((_fromRow > _toRow || _fromCol > _toCol) && (_toRow!=0)) //_toRow==0 is #REF!
             {
                 throw new ArgumentOutOfRangeException("Start cell Address must be less or equal to End cell address");
             }
@@ -1418,12 +1418,13 @@ public string LocalAddress
         { 
             get
             {
-                var ix = _address.TrimEnd().LastIndexOf('!', _address.Length - 2);  //Last index can be ! if address is #REF!, so check from 
+                var localAddress = FirstAddress;
+                var ix = localAddress.TrimEnd().LastIndexOf('!', localAddress.Length - 2);  //Last index can be ! if address is #REF!, so check from 
                 if (ix>=0)
                 {
-                    return _address.Substring(ix + 1);
+                    return localAddress.Substring(ix + 1);
                 }
-                return _address;
+                return localAddress;
             }
         }
         /// <summary>

src/EPPlus/ExcelCellBase.cs

@@ -290,9 +290,9 @@ internal static bool GetRowColFromAddress(string CellAddress, out int FromRow, o
                         FromColumn = 1;
                     if (FromRow <= 0)
                         FromRow = 1;
-                    if (ToColumn <= 0)
+                    if (ToColumn <= 0 && (cells.Length<=1 || (cells.Length > 1 && cells[1].Equals("#REF!",StringComparison.OrdinalIgnoreCase) == false)))
                         ToColumn = ExcelPackage.MaxColumns;
-                    if (ToRow <= 0)
+                    if (ToRow <= 0 && (cells.Length <= 1 || (cells.Length > 1 && cells[1].Equals("#REF!", StringComparison.OrdinalIgnoreCase) == false)))
                         ToRow = ExcelPackage.MaxRows;
 
                 }
@@ -320,6 +320,7 @@ private static void SetToRowCol(ref int toRowCol, ref bool fixedToRowCol, int ro
 
         private static bool IsCellAddress(string cellAddress)
         {
+            if (cellAddress.Equals("#REF!", StringComparison.OrdinalIgnoreCase)) return true;
             int  alpha = 0;
             bool num = false;
             for(int i=0;i<cellAddress.Length;i++)
@@ -653,7 +654,7 @@ internal static string GetFullAddress(string worksheetName, string address, bool
             {
                 wsForAddress = GetQuotedWorksheetName(worksheetName);
             }
-            if (address.IndexOf('!') == -1 || address == "#REF!")
+            if (address.IndexOf('!') == -1 || address.Contains("#REF!"))
             {
                 if (fullRowCol)
                 {