Merge pull request #1339 from peverwhee/rrtmgp-fileio

cam6_4_108: Bring in file i/o object and update interfaces for CCPPized RRTMGP

Author: peverwhee

.gitmodules

@@ -36,10 +36,18 @@
 [submodule "atmos_phys"]
 	path = src/atmos_phys
 	url = https://github.com/ESCOMP/atmospheric_physics
-        fxtag = dev_atmos_phys0_15_000
+        fxtag = atmos_phys0_15_000
         fxrequired = AlwaysRequired
 	fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics
 
+[submodule "cam-sima"]
+        path = src/utils/cam-sima
+        url = https://github.com/ESCOMP/CAM-SIMA.git
+        fxrequired = AlwaysRequired
+        fxsparse = ../.sima_phys_utils_sparse_checkout
+        fxtag = sima0_07_000
+        fxDONOTUSEurl = https://github.com/ESCOMP/CAM-SIMA.git
+
 [submodule "fv3"]
 	path = src/dynamics/fv3
 	url = https://github.com/ESCOMP/CAM_FV3_interface.git

bld/configure

@@ -2172,6 +2172,7 @@ sub write_filepath
     # in the list of filepaths.
     print $fh "$camsrcdir/src/physics/cam\n";
     print $fh "$camsrcdir/src/atmos_phys/to_be_ccppized\n";
+    print $fh "$camsrcdir/src/atmos_phys/to_be_ccppized/radiation_utils\n";
     print $fh "$camsrcdir/src/atmos_phys/phys_utils\n";
 
     # Add the CCPP'ized subdirectories
@@ -2208,6 +2209,9 @@ sub write_filepath
     print $fh "$camsrcdir/src/utils\n";
     print $fh "$camsrcdir/src/utils/cam_ccpp\n";
 
+    # Routines from CAM-SIMA
+    print $fh "$camsrcdir/src/utils/cam-sima/src/physics/utils\n";
+
     $fh->close;
 }
 

doc/ChangeLog

@@ -1,5 +1,110 @@
 ===============================================================
 
+Tag name: cam6_4_108
+Originator(s): peverwhee
+Date: August 19, 2025
+One-line Summary: Bring in file i/o object and update interfaces for CCPPized RRTMGP
+Github PR URL: https://github.com/ESCOMP/CAM/pull/1339
+
+Purpose of changes (include the issue number and title text for each relevant GitHub issue):
+- Bring in sparsely-checked-out CAM-SIMA as submodule to grab file i/o object
+- Bring in new atmospheric physics tag that incorporates the file i/o object
+  into RRTMGP
+- Update calling lists to match new interfaces (in `rrtmgp/radiation.F90` and
+  `src/physics/cam/cloud_rad_props.F90`
+- Removes file reading from cloud_rad_props.F90 and instead calls new CCPP
+  interface
+
+Describe any changes made to build system:
+M       bld/configure
+        - Add new to_be_ccppized subdirectory
+
+Describe any changes made to the namelist: N/A
+
+List any changes to the defaults for the boundary datasets: N/A
+
+Describe any substantial timing or memory changes: N/A
+
+Code reviewed by: cacraigucar
+
+List all files eliminated: N/A
+
+List all files added and what they do:
+A       src/utils/.sima_phys_utils_sparse_checkout
+A       src/utils/cam-sima
+        - bring in new CAM-SIMA submodule (sparse check out)
+
+List all existing files that have been modified, and describe the changes:
+M       .gitmodules
+        - Update atmos_phys external tag
+        - Add new CAM-SIMA external
+
+M       src/atmos_phys
+        - updated atmospheric_physics submodule
+
+M       src/physics/cam/cloud_rad_props.F90
+        - call CCPPized scheme to read ice and liquid optics files
+
+M       src/physics/cam/radheat.F90
+        - add missing "_r8"s
+
+M       src/physics/rrtmg/radiation.F90
+        - update interface to cloud_rad_props_init
+
+M       src/physics/rrtmgp/radiation.F90
+        - update interfaces to CCPPized schemes
+        - delete coefs_init subroutine (ccppized)
+
+M       src/utils/cam_pio_utils.F90
+        - add "errcode" variable to cam_pio_openfile to be used by ccpp i/o
+          reader
+
+If there were any failures reported from running test_driver.sh on any test
+platform, and checkin with these failures has been OK'd by the gatekeeper,
+then copy the lines from the td.*.status files for the failed tests to the
+appropriate machine below.  All failed tests must be justified.
+
+derecho/intel/aux_cam:
+  ERP_Ld3.ne30pg3_ne30pg3_mt232.FHISTC_MTt4s.derecho_intel.cam-outfrq1d_aoa (Overall: DIFF) details:
+  SMS_D_Ln9.ne30pg3_ne30pg3_mt232.FHISTC_MTso.derecho_intel.cam-outfrq9s (Overall: DIFF) details:
+  SMS_D_Ln9_P1280x1.ne30pg3_ne30pg3_mt232.FHISTC_MTt1s.derecho_intel.cam-outfrq9s_Leung_dust (Overall: DIFF) details:
+    - MT answer changes are expected (added "_r8"s)
+
+  SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
+    - pre-existing failure due to build-namelist error requiring CLM/CTSM external update.
+
+derecho/nvhpc/aux_cam: BFB
+
+izumi/nag/aux_cam: all BFB
+
+izumi/gnu/aux_cam: all BFB
+
+CAM tag used for the baseline comparison tests if different than previous
+tag:
+
+Summarize any changes to answers, i.e.,
+- what code configurations:
+- what platforms/compilers:
+- nature of change (roundoff; larger than roundoff but same climate; new
+  climate):
+
+If bitwise differences were observed, how did you show they were no worse
+than roundoff?
+
+If this tag changes climate describe the run(s) done to evaluate the new
+climate in enough detail that it(they) could be reproduced, i.e.,
+- source tag (all code used must be in the repository):
+- platform/compilers:
+- configure commandline:
+- build-namelist command (or complete namelist):
+- MSS location of output:
+
+MSS location of control simulations used to validate new climate:
+
+URL for AMWG diagnostics output used to validate new climate:
+
+===============================================================
+
 Tag name: cam6_4_107
 Originator(s): JulioTBacmeister, perverwhee, cacraigucar
 Date: August 13, 2025