|
1 | 1 | =============================================================== |
2 | 2 |
|
| 3 | +Tag name: cam6_4_133 |
| 4 | +Originator(s): jimmielin, jtruesdal |
| 5 | +Date: Nov 28, 2025 |
| 6 | +One-line Summary: Complete CCPPization of all gravity wave drag |
| 7 | +Github PR URL: https://github.com/ESCOMP/CAM/pull/1380 |
| 8 | + |
| 9 | +Purpose of changes (include the issue number and title text for each relevant GitHub issue): |
| 10 | +- Completes #416: |
| 11 | +- Move all gravity wave parameterizations to atmos_phys. |
| 12 | +- Complete CCPPization of necessary interstitials. |
| 13 | +- Complete CCPPization of orographic gravity wave drag for CAM4. |
| 14 | +- Complete CCPPization of Ridge (beta/gamma), Moving Mountain, Beres convection (deep/shallow), and Frontogenesis gravity wave drag for CAM6/7. |
| 15 | + |
| 16 | +Describe any changes made to build system: |
| 17 | +- Add gravity wave drag scheme subdirectory to atmos_phys. |
| 18 | + |
| 19 | +Describe any changes made to the namelist: |
| 20 | +- Minor typo fixes; removal of certain unused parameters |
| 21 | + |
| 22 | +List any changes to the defaults for the boundary datasets: |
| 23 | +- Topo file for ne3np4 |
| 24 | + |
| 25 | +Describe any substantial timing or memory changes: N/A |
| 26 | + |
| 27 | +Code reviewed by: nusbaume |
| 28 | + |
| 29 | +List all files eliminated: |
| 30 | +D src/physics/cam/gw_common.F90 |
| 31 | +D src/physics/cam/gw_convect.F90 |
| 32 | +D src/physics/cam/gw_diffusion.F90 |
| 33 | +D src/physics/cam/gw_front.F90 |
| 34 | +D src/physics/cam/gw_movmtn.F90 |
| 35 | +D src/physics/cam/gw_oro.F90 |
| 36 | +D src/physics/cam/gw_rdg.F90 |
| 37 | +D src/physics/cam/gw_utils.F90 |
| 38 | + - moved to atmos_phys, cleaned up, CCPPized, renamed. |
| 39 | + |
| 40 | +D src/physics/cam/vdiff_lu_solver.F90 |
| 41 | + - moved to atmos_phys/to_be_ccppized. |
| 42 | + |
| 43 | +D src/physics/cam/gw_drag.F90 |
| 44 | + - moved to gw_drag_cam and made into a CAM interface to CCPPized subroutines. |
| 45 | + |
| 46 | +List all files added and what they do: |
| 47 | +A src/physics/cam/gw_drag_cam.F90 |
| 48 | + - new CAM interface to CCPPized subroutines. |
| 49 | + |
| 50 | +List all existing files that have been modified, and describe the changes: |
| 51 | +M .gitmodules |
| 52 | +M bld/configure |
| 53 | + - add new gw_drag subdir in atmos_phys. |
| 54 | + |
| 55 | +M bld/namelist_files/namelist_defaults_cam.xml |
| 56 | + - new ne3np4 topo file |
| 57 | + |
| 58 | +M bld/namelist_files/namelist_definition.xml |
| 59 | +M bld/build-namelist |
| 60 | + - minor typo fixes |
| 61 | + - removal of unused parameters in namelist. |
| 62 | + |
| 63 | +M src/control/runtime_opts.F90 |
| 64 | +M src/physics/cam/physpkg.F90 |
| 65 | +M src/physics/cam7/physpkg.F90 |
| 66 | + - change to use gw_drag_cam CAM interfaces. |
| 67 | + |
| 68 | +M src/utils/cam_pio_utils.F90 |
| 69 | + - remove trailing whitespace |
| 70 | + |
| 71 | +If there were any failures reported from running test_driver.sh on any test |
| 72 | +platform, and checkin with these failures has been OK'd by the gatekeeper, |
| 73 | +then copy the lines from the td.*.status files for the failed tests to the |
| 74 | +appropriate machine below. All failed tests must be justified. |
| 75 | + |
| 76 | +derecho/intel/aux_cam: |
| 77 | + ERC_D_Ln9.f09_f09_mt232.FHIST_BDRD.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 78 | + ERC_D_Ln9.f19_f19_mg17.QPMOZ.derecho_intel.cam-outfrq3s (Overall: NLFAIL) details: |
| 79 | + ERC_D_Ln9.f19_f19_mt232.QPC6.derecho_intel.cam-outfrq3s_cosp (Overall: NLFAIL) details: |
| 80 | + ERC_D_Ln9.mpasa120_mpasa120.F2000climo.derecho_intel.cam-outfrq9s_mpasa120 (Overall: NLFAIL) details: |
| 81 | + ERC_D_Ln9.mpasa120_mpasa120.FHISTC_LTso.derecho_intel.cam-outfrq9s_mpasa120 (Overall: NLFAIL) details: |
| 82 | + ERC_D_Ln9.mpasa120_mpasa120.QPC7.derecho_intel.cam-outfrq9s_mpasa120 (Overall: NLFAIL) details: |
| 83 | + ERC_D_Ln9.ne30pg2_ne30pg2_mt232.QPC7.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 84 | + ERC_D_Ln9.ne30pg3_ne30pg3_mt232.F1850C_LTso.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 85 | + ERC_Ln9.C96_C96_mt232.F2000climo.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 86 | + ERI_D_Ln18.f09_f09_mt232.FHIST.derecho_intel.cam-outfrq3s_eri (Overall: NLFAIL) details: |
| 87 | + ERI_D_Ln18.f19_f19_mt232.FHIST_C5.derecho_intel.cam-outfrq3s_eri (Overall: NLFAIL) details: |
| 88 | + ERI_D_Ln18.ne16pg3_ne16pg3_mt232.FHIST_C4.derecho_intel.cam-outfrq3s_eri (Overall: NLFAIL) details: |
| 89 | + ERI_D_Ln18.ne30pg3_ne30pg3_mt232.FHISTC_LTso.derecho_intel.cam-outfrq3s_eri (Overall: NLFAIL) details: |
| 90 | + ERP_D_Ln9.ne30pg3_ne30pg3_mt232.F1850C_MTso.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 91 | + ERP_D_Ln9_P64x2.f09_f09_mg17.QSC6.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 92 | + ERP_Ld3.ne16pg3_ne16pg3_mg17.FHISTC_WAt1ma.derecho_intel.cam-reduced_hist1d (Overall: NLFAIL) details: |
| 93 | + ERP_Ld3.ne30pg3_ne30pg3_mt232.FHISTC_MTt4s.derecho_intel.cam-outfrq1d_aoa (Overall: NLFAIL) details: |
| 94 | + ERP_Lh12.f19_f19_mg17.FW4madSD.derecho_intel.cam-outfrq3h (Overall: NLFAIL) details: |
| 95 | + ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 96 | + ERP_Ln9.f19_f19_mg17.FWsc1850.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 97 | + ERP_Ln9.ne30pg3_ne30pg3_mg17.FCnudged.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 98 | + ERP_Ln9.ne30pg3_ne30pg3_mg17.FHISTC_WAma.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 99 | + ERR_Ln9.ne16pg3_ne16pg3_mt232.FHISTC_LTso.derecho_intel.cam-outfrq9s_bwic (Overall: NLFAIL) details: |
| 100 | + ERS_Ln9.f09_f09_mg17.FX2000.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 101 | + ERS_Ln9.f19_f19_mg17.FXSD.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 102 | + ERS_Ln9.ne30pg3_ne30pg3_mg17.FHISTC_WXma.derecho_intel.cam-outfrq9s_ctem (Overall: NLFAIL) details: |
| 103 | + SCT_D_Ln7.ne3_ne3_mg37.QPC5.derecho_intel.cam-scm_prep (Overall: NLFAIL) details: |
| 104 | + SMS_C2_D_Ln9.ne16pg3_ne16pg3_mg17.FHISTC_WXma.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 105 | + SMS_D_Ld5.f09_f09_mt232.PC6.derecho_intel.cam-cam6_port_f09 (Overall: NLFAIL) details: |
| 106 | + SMS_D_Ld5.f19_f19_mt232.PC4.derecho_intel.cam-cam4_port5d (Overall: NLFAIL) details: |
| 107 | + SMS_D_Ln9.f09_f09_mg17.FCts2nudged.derecho_intel.cam-outfrq9s_leapday (Overall: NLFAIL) details: |
| 108 | + SMS_D_Ln9.f09_f09_mg17.FCvbsxHIST.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 109 | + SMS_D_Ln9.f09_f09_mg17.FSD.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 110 | + SMS_D_Ln9.f19_f19_mg17.FWma2000climo.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 111 | + SMS_D_Ln9.f19_f19_mg17.FWma2000climo.derecho_intel.cam-outfrq9s_waccm_ma_mam4 (Overall: NLFAIL) details: |
| 112 | + SMS_D_Ln9.f19_f19_mg17.QPC2000climo.derecho_intel.cam-outfrq3s_usecase (Overall: NLFAIL) details: |
| 113 | + SMS_D_Ln9.f19_f19_mt232.FHIST_C5.derecho_intel.cam-mam7 (Overall: NLFAIL) details: |
| 114 | + SMS_D_Ln9.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 115 | + SMS_D_Ln9.ne16_ne16_mg17.QPX2000.derecho_intel.cam-outfrq9s_amie (Overall: NLFAIL) details: |
| 116 | + SMS_D_Ln9.ne30pg3_ne30pg3_mt232.FHISTC_MTso.derecho_intel.cam-outfrq9s (Overall: NLFAIL) details: |
| 117 | + SMS_D_Ln9_P1280x1.ne30pg3_ne30pg3_mt232.FHISTC_MTt1s.derecho_intel.cam-outfrq9s_Leung_dust (Overall: NLFAIL) details: |
| 118 | + SMS_Ld1.f09_f09_mg17.FCHIST_GC.derecho_intel.cam-outfrq1d (Overall: NLFAIL) details: |
| 119 | + SMS_Ld1.f09_f09_mg17.FW2000climo.derecho_intel.cam-outfrq1d (Overall: NLFAIL) details: |
| 120 | + SMS_Ld1.ne30pg3_ne30pg3_mg17.FC2010climo.derecho_intel.cam-outfrq1d (Overall: NLFAIL) details: |
| 121 | + SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h (Overall: NLFAIL) details: |
| 122 | + SMS_Ln9.f09_f09_mg17.F2010climo.derecho_intel.cam-nudging (Overall: NLFAIL) details: |
| 123 | + SMS_Ln9.f09_f09_mg17.FW1850.derecho_intel.cam-reduced_hist3s (Overall: NLFAIL) details: |
| 124 | + SMS_Ln9.f19_f19_mt232.F2000climo.derecho_intel.cam-silhs (Overall: NLFAIL) details: |
| 125 | + SMS_Ln9.ne30pg3_ne30pg3_mg17.FW2000climo.derecho_intel.cam-outfrq9s_rrtmgp (Overall: NLFAIL) details: |
| 126 | + - removed unused namelist parameter leading to NLCOMP failure: |
| 127 | + missing variable: 'gw_limit_tau_without_eff' |
| 128 | + |
| 129 | + SMS_D_Ln9_P1536x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: DIFF) details: |
| 130 | + - baselines from previous tag cam6_4_132 were missing due to pre-existing failure: |
| 131 | + - intermittent failure in CTSM code (lnd_set_decomp_and_domain.F90) |
| 132 | + |
| 133 | +derecho/nvhpc/aux_cam: |
| 134 | + ERS_Ln9.ne30pg3_ne30pg3_mt232.FHISTC_LTso.derecho_nvhpc.cam-outfrq9s_gpu_default (Overall: FAIL) details: |
| 135 | + - pre-existing failure: |
| 136 | + - timing issue - Jian has determined this is due to changes on derecho with the the last upgrade. He has |
| 137 | + reported the issue to CISL. Note cam6_4_128 is the last CAM tag with baselines to use for comparison |
| 138 | + but answer changes are expected starting with cam6_4_130 |
| 139 | + |
| 140 | +izumi/nag/aux_cam: |
| 141 | + ERC_D_Ln9.f10_f10_mg37.QPWmaC6.izumi_nag.cam-outfrq3s (Overall: NLFAIL) details: |
| 142 | + ERC_D_Ln9.f10_f10_mt232.FHIST_C5.izumi_nag.cam-outfrq3s_subcol (Overall: NLFAIL) details: |
| 143 | + ERC_D_Ln9.f10_f10_mt232.FHIST.izumi_nag.cam-outfrq3s_cospsathist (Overall: NLFAIL) details: |
| 144 | + ERC_D_Ln9.mpasa480_mpasa480_mt232.QPC7.izumi_nag.cam-outfrq9s_mpasa480 (Overall: NLFAIL) details: |
| 145 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.FHISTC_LTso.izumi_nag.cam-cosp_rad_diags (Overall: NLFAIL) details: |
| 146 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.FHISTC_LTso.izumi_nag.cam-outfrq9s_nochem (Overall: NLFAIL) details: |
| 147 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.QPC4.izumi_nag.cam-outfrq9s (Overall: NLFAIL) details: |
| 148 | + SMS_D_Ld2.f45_f45_mg37.PC5.izumi_nag.cam-outfrq24h_port (Overall: NLFAIL) details: |
| 149 | + SMS_D_Ln3.ne5pg3_ne5pg3_mg37.QPX2000.izumi_nag.cam-outfrq3s (Overall: NLFAIL) details: |
| 150 | + SMS_D_Ln6.ne5_ne5_mg37.QPWmaC4.izumi_nag.cam-outfrq3s_physgrid_tem (Overall: NLFAIL) details: |
| 151 | + SMS_D_Ln9.f10_f10_mt232.F1850.izumi_nag.cam-outfrq9s (Overall: NLFAIL) details: |
| 152 | + TMC_D_Ln9.f10_f10_mt232.FHIST_C5.izumi_nag.cam-mc_ttrac (Overall: NLFAIL) details: |
| 153 | + - removed unused namelist parameter leading to NLCOMP failure: |
| 154 | + missing variable: 'gw_limit_tau_without_eff' |
| 155 | + |
| 156 | +izumi/gnu/aux_cam: |
| 157 | + ERC_D_Ln9.C48_C48_mg17.QPC6.izumi_gnu.cam-outfrq9s (Overall: NLFAIL) details: |
| 158 | + ERC_D_Ln9.f10_f10_mg37.QPC4.izumi_gnu.cam-outfrq3s_diags (Overall: NLFAIL) details: |
| 159 | + ERC_D_Ln9.f10_f10_mt232.FHIST_C5.izumi_gnu.cam-rad_diag (Overall: NLFAIL) details: |
| 160 | + ERC_D_Ln9.f19_f19_mt232.FHIST.izumi_gnu.cam-lonlat_fv_diags (Overall: NLFAIL) details: |
| 161 | + ERC_D_Ln9.mpasa480_mpasa480_mt232.FHISTC_LTso.izumi_gnu.cam-outfrq9s_mpasa480 (Overall: NLFAIL) details: |
| 162 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.F1850_C4.izumi_gnu.cam-co2rmp (Overall: NLFAIL) details: |
| 163 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.FHIST_C5.izumi_gnu.cam-carma_cosp_rad_diag_mam (Overall: NLFAIL) details: |
| 164 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.FHISTC_LTso.izumi_gnu.cam-sat_lcltod (Overall: NLFAIL) details: |
| 165 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.FHIST.izumi_gnu.cam-nochem_clubbmf (Overall: NLFAIL) details: |
| 166 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.QPC5.izumi_gnu.cam-outfrq9s (Overall: NLFAIL) details: |
| 167 | + ERC_D_Ln9.ne3pg3_ne3pg3_mt232.QPC7.izumi_gnu.cam-outfrq9s (Overall: NLFAIL) details: |
| 168 | + ERC_D_Ln9.ne5_ne5_mg37.QPC4.izumi_gnu.cam-outfrq3s_nudging_ne5_L26 (Overall: NLFAIL) details: |
| 169 | + ERP_Ln9_P24x2.f45_f45_mg37.QPWmaC6.izumi_gnu.cam-outfrq9s_mee_fluxes (Overall: NLFAIL) details: |
| 170 | + ERS_Ln9_P24x1.mpasa480_mpasa480.F2000climo.izumi_gnu.cam-outfrq9s_mpasa480 (Overall: NLFAIL) details: |
| 171 | + PLB_D_Ln9.f10_f10_mt232.FHIST_C5.izumi_gnu.cam-ttrac_loadbal0 (Overall: NLFAIL) details: |
| 172 | + PLB_D_Ln9.f10_f10_mt232.FHIST_C5.izumi_gnu.cam-ttrac_loadbal1 (Overall: NLFAIL) details: |
| 173 | + PLB_D_Ln9.f10_f10_mt232.FHIST_C5.izumi_gnu.cam-ttrac_loadbal3 (Overall: NLFAIL) details: |
| 174 | + SCT_D_Ln7.ne3_ne3_mg37.QPC6.izumi_gnu.cam-scm_prep_c6 (Overall: NLFAIL) details: |
| 175 | + SMS_D_Ln3.f10_f10_mg37.QPMOZ.izumi_gnu.cam-outfrq3s_chemproc (Overall: NLFAIL) details: |
| 176 | + SMS_D_Ln3.ne3pg3_ne3pg3_mt232.PC7.izumi_gnu.cam-pc7_ne3pg3 (Overall: NLFAIL) details: |
| 177 | + SMS_D_Ln9.f10_f10_mg37.QPWmaC4.izumi_gnu.cam-outfrq9s_apmee (Overall: NLFAIL) details: |
| 178 | + SMS_D_Ln9.f19_f19_mt232.FW4madSD.izumi_gnu.cam-outfrq9s (Overall: NLFAIL) details: |
| 179 | + SUB_D_Ln9.ne3pg3_ne3pg3_mt232.FHIST.izumi_gnu.cam-outfrq9s (Overall: NLFAIL) details: |
| 180 | + - removed unused namelist parameter leading to NLCOMP failure: |
| 181 | + missing variable: 'gw_limit_tau_without_eff' |
| 182 | + |
| 183 | +CAM tag used for the baseline comparison tests if different than previous |
| 184 | +tag: nvhpc has failed after Derecho update so using cam6_4_128 baselines. |
| 185 | + |
| 186 | +Summarize any changes to answers: All B4B |
| 187 | + |
| 188 | +If bitwise differences were observed, how did you show they were no worse |
| 189 | +than roundoff? |
| 190 | + |
| 191 | +=============================================================== |
| 192 | + |
3 | 193 | Tag name: cam6_4_132 |
4 | 194 | Originator(s): peverwhee, jimmielin, cacraigucar, nusbaume |
5 | 195 | Date: Nov 26, 2025 |
|
0 commit comments