Merge tag 'ctsm5.3.046' into b4b-dev-merge-20250524

For FATES set itype to ispval and a few unused variables to nan

On FATES patches, there should be no notion of pft associated with the
patch, and therefore patch%itype should always be invalid.
Even for FATES-SP, the patch should be associated with the FATES pft,
which is not associated with itype. In this set of changes,
itype is set to spval on fates patches. This will help prevent bugs in
the future, because its use in a fates context should trigger
errors, particularly in debug mode.

When FATES with itype tset o ispval which when used in DEBUG mode will
show up as a bounds overflow.
For example in issue 2932, where the use of Meier 2022 was turned on in
FATES and shouldn't have been.

For FATES also set the fields downreg, leafn, froot, and croot t NaN, so
when used in DEBUG mode their use will result in a floting
point exception.

Author: samsrabin

doc/ChangeLog

@@ -1,4 +1,99 @@
 ===============================================================
+Tag name: ctsm5.3.046
+Originator(s): rgknox (Ryan Knox)
+Date: Mon 26 May 2025 02:45:52 AM MDT
+One-line Summary: For FATES set itype to ispval and a few unused variables to nan to help prevent future problems
+
+Purpose and description of changes
+----------------------------------
+
+
+On FATES patches, there should be no notion of pft associated with the patch, and therefore patch%itype should always be invalid.
+Even for FATES-SP, the patch should be associated with the FATES pft, which is not associated with itype. In this set of changes,
+itype is set to spval on fates patches. This will help prevent bugs in the future, because its use in a fates context should trigger
+errors, particularly in debug mode.
+
+When FATES with itype tset o ispval which when used in DEBUG mode will show up as a bounds overflow.
+For example in issue 2932, where the use of Meier 2022 was turned on in FATES and shouldn't have been.
+
+For FATES also set the fields downreg, leafn, froot, and croot t NaN, so when used in DEBUG mode their use will result in a floting
+point exception.
+
+
+Significant changes to scientifically-supported configurations
+--------------------------------------------------------------
+
+Does this tag change answers significantly for any of the following physics configurations?
+(Details of any changes will be given in the "Answer changes" section below.)
+
+    [Put an [X] in the box for any configuration with significant answer changes.]
+
+[ ] clm6_0
+
+[ ] clm5_0
+
+[ ] ctsm5_0-nwp
+
+[ ] clm4_5
+
+
+Bugs fixed
+----------
+
+List of CTSM issues fixed (include CTSM Issue # and description) [one per line]:
+   Fixed #2933 -- setting patch%itype to invalid for FATES patches
+
+Notes of particular relevance for users
+---------------------------------------
+
+Changes to CTSM's user interface (e.g., new/renamed XML or namelist variables):
+   Dissallow drydep or MEGAN for all FATES types including FatesSp and die with
+   a fatal_error, rather than a warning
+
+Notes of particular relevance for developers:
+---------------------------------------------
+
+Caveats for developers (e.g., code that is duplicated that requires double maintenance):
+   Unfrtunately setting itype doesn't fix all possible problems with 
+   See discussin #2149
+
+Changes to tests or testing:
+   Disable FatesSp drydep and MEGAN tests
+
+Testing summary: regular fates
+----------------
+ [PASS means all tests PASS; OK means tests PASS other than expected fails.]
+
+  build-namelist tests (if CLMBuildNamelist.pm has changed):
+
+    derecho - OK
+
+  python testing (if python code has changed; see instructions in python/README.md; document testing done):
+
+    derecho - PASS
+
+  regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):
+
+    derecho ----- OK
+    izumi ------- OK
+
+If the tag used for baseline comparisons was NOT the previous tag, note that here:
+
+
+Answer changes
+--------------
+
+Changes answers relative to baseline: No bit-fr-bit
+
+Other details
+-------------
+
+Pull Requests that document the changes (include PR ids):
+(https://github.com/ESCOMP/ctsm/pull)
+   https://github.com/ESCOMP/CTSM/pull/2935
+
+===============================================================
+===============================================================
 Tag name: ctsm5.3.045
 Originator(s): glemieux (Gregory Lemieux, LBNL, [email protected])
 Date: Tue May 20 11:56:15 MDT 2025

doc/ChangeSum

@@ -1,5 +1,6 @@
 Tag                   Who      Date  Summary
 ============================================================================================================================
+       ctsm5.3.046   rgknox 05/26/2025 For FATES set itype to ispval and a few unused variables to nan to help prevent future problems
        ctsm5.3.045 glemieux 05/20/2025 FATES default parameter update for API 40
        ctsm5.3.044   slevis 05/14/2025 Introduce time-evolving LEAFCN_TARGET as function of leafcn param
        ctsm5.3.043   slevis 05/09/2025 Merge b4b-dev