Skip to content

Conversation

@ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Feb 4, 2025

Description of changes

Various updates for testing and other problems identified in the cesm3_0_beta04 tag. So fixes and cleanup for usability.
Including the following:

  • Fix SHR_ASSERT so single-point matrix test passes
  • ne3np4 to namelist_defaults_ctsm.xml and Makefile for PTS mode and add ability for warm starts in PTS mode
  • f19 + f45 16pft fsurdat/landuse files to namelist_defaults_ctsm + Makefile
  • Changes in the FORTRAN code to properly abort when fire-emission is asked for it can't be provided. Added unit testing for this.

Specific notes

Contributors other than yourself, if any: @slevis-lmwg

CTSM Issues Fixed (include github issue #):
Fixes #2868
Fixes #2791
Fixes #2768
Fixes #2780
Fixes #2762
Fixes #3073
Some of #2810
CTSM namelist checking for: NGEET/fates#1356
Some work on #2643

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: regular

PR's Involved:

#2840
#2835
#2834
#2844

ekluzek and others added 30 commits October 3, 2024 16:01
…efile

slevis resolved conflicts:
bld/unit_testers/build-namelist_test.pl
Bring back clm5-cam6 init_interp_attributes for ne0CONUS grid
…file

ne3np4 to namelist_defaults_ctsm.xml and Makefile for PTS mode and add ability for warm starts in PTS mode
ekluzek added 2 commits June 14, 2025 02:21
Fix PEM test for FATES testmod that builds an on-the-fly parameter file
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 14, 2025

I updated to ctsm5.3.057 and testing for aux_clm is passing as expected on Derecho and Izumi.

ekluzek and others added 2 commits June 14, 2025 11:46
branch with 5.3.05Y: Make sure FORTRAN code properly aborts when fire-emission is asked for and it can't be provided
@ekluzek ekluzek requested a review from slevis-lmwg June 14, 2025 23:43
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing the part of this that comes in with #2844 since the other PRs were mine.

The title of #2844 predisposed me to expect a short PR with few code changes. This turns out to be a major (in my perception) refactor, plus an addition of unit tests. Thank you for all this @ekluzek!

I included a few questions. Nothing stood out as problematic to me.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 17, 2025

I ran some extra tests to make sure the issues were resolved. These PASS:

PEA.1x1_smallvilleIA.IHistClm50BgcCropQianRs.derecho_gnu.clm-smallville_dynurban_monthly
PEA_D.1x1_smallvilleIA.IHistClm50BgcCropQianRs.derecho_gnu.clm-smallville_dynurban_monthly
SEQ_D_PS.f09_f09_mt232.I1850Clm50Sp.derecho_intel.clm-default--clm-nofireemis
SEQ_PS.f09_f09_mt232.I1850Clm50Sp.derecho_intel.clm-default--clm-nofireemis
SMS_D_Ln9.f19_f19_mg17.FWma2000climo.derecho_intel.cam-outfrq9s_waccm_ma_mam4
SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s
SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCnudged.derecho_intel.cam-outfrq9s
SMS_Ld12_Mmpi-serial.1x1_vancouverCAN.I1PtClm60SpRs.derecho_gnu.clm-output_sp_highfreq
SMS_Ln9.ne3pg3_ne3pg3_mg37.I2000Clm50Sp.derecho_gnu.clm-clm50cam6LndTuningMode--clm-nofireemis
SMS_Ly1_Mmpi-serial.1x1_brazil.IHistClm60BgcQianRs.derecho_intel.clm-output_bgc_highfreq
SSPMATRIXCN_Ly5_Mmpi-serial.1x1_numaIA.I2000Clm60BgcCropQianRs.derecho_intel.clm-ciso_monthly

These fail and need to be figured out:

ERS_Ld3.f19_f19_mg17.FXHIST.derecho_intel.cam-waccmx_weimer (SETUP)
SMS_D_Ln9.f19_f19_mg17.FXHIST.derecho_intel.cam-outfrq9s_amie (SETUP)
SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s (NLCOMP RUN)

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 18, 2025

It looks like the problem with the f19 tests are the unusual RUN_STARTDATE of: 2005-12-31 and 2003-10-28. It fails with the problem we have been seeing where use_init_interp isn't coordinated correctly with the IC files.

The ARCTIC grid fails in an ESMF regrid and I think it's likely due to too few processors. The default for CAM is 91 nodes, which is 11k tasks, so 10X larger than the tasks asked for. So I think it will likely work with more processors.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 18, 2025

Since, I had some variety of tests failing, I sent the ctsm_sci test list and these tests failed as they need the --clm-nofireemis added as an extra testmod to them.

SMS_Ld5.f09_g17.IHistClm50SpCru.derecho_intel.clm-default (SETUP)
SMS_Ld5.f19_g17.IHistClm50SpCru.derecho_intel.clm-default (SETUP)
SMS_Lm12.f09_f09_mg17.I1850Clm60Sp.derecho_intel.clm-ExcessIceStartup_output_sp_exice (SETUP)
SMS_Lm12.f09_t232.I1850Clm60SpCrujra.derecho_intel.clm-ExcessIceStartup_output_sp_exice (SETUP)

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 20, 2025

In the meeting this morning, I was encouraged to make the tag as is. And file issues for anything outstanding. I have created baselines that just need to be renamed. And I'll start the ChangeLog.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 23, 2025

Some tests have different answers because the fieldlists change because fire-emission is off.

ERP_D_Ld3_PS.f09_g17.I2000Clm50Sp.derecho_intel.clm-prescribed
ERS_D_Ld10.f10_f10_mg37.IHistClm50Sp.derecho_intel.clm-collapse_pfts_78_to_16_decStart_f10
SMS_C2_D_Lh12.f10_f10_mg37.I2000Clm50Sp.derecho_intel.clm-pauseResume
SMS_D_Ln9_P128x3.f19_g17.IHistClm50Sp.derecho_intel.clm-waccmx_offline
ERI_D_Ld9_P48x1.f10_f10_mg37.I2000Clm50Sp.izumi_nag.clm-SNICARFRC
ERP_D_Ld5_P48x1.f10_f10_mg37.I2000Clm50Sp.izumi_nag.clm-o3lombardozzi2015
ERS_D.f10_f10_mg37.I1850Clm60Sp.izumi_nag.clm-ExcessIceStreams

Also the ctsm_sci comparison to ctsm5.3.051 changes answers for VOC's because the MEGAN change came in just after that.

@ekluzek ekluzek merged commit 586286b into master Jun 23, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in LMWG: Sprint Planning Board Jun 23, 2025
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Jun 23, 2025
@ekluzek ekluzek deleted the cesm3_0_beta04_changes branch October 10, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations test: aux_clm Pass aux_clm suite before merging test: python Pass clm_pymods test suite plus Python sys/unit tests before merging usability Improve or clarify user-facing options

Projects

Status: Done (non release/external)
Status: Done

6 participants