-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Description
Currently, in MOM_input.yaml, we place parameters that don't belong to any modules under the Global block, and module parameters under respoective module blocks. For instance:
Global:
INPUTDIR:
...
TRIPOLAR_N:
...
KPP:
N_SMOOTH:
...
STOKES_MOST
...
MLE:
USE_BODNER23:
...
CR:
...
Given the size of this file, it's easy to make mistakes, where a parameter may inadvertently be placed under a module it doesn't belong to.
I have two improvement suggestions.
- Rather than having module blocks, explicitlyspecify module names in parameter names. So the above entries would look like:
INPUTDIR:
...
TRIPOLAR_N:
...
KPP%N_SMOOTH:
...
KPP%STOKES_MOST
...
MLE%USE_BODNER23:
...
MLE%CR:
...
- Turn relevant warnings into failures.
Metadata
Metadata
Assignees
Labels
No labels