Fix test_unit_xml_tests for new case.get_value call

The previous commit introduced an extra call to case.get_value to get
SYSTEM_TESTS_DIR for component=allactive. This broke the mock get_value
returns. To make these returns more robust, I have changed the way
they're done to be based on a dictionary lookup rather than an ordered
list.

This kind of replacement should probably be done for other
case.get_value mocks. Note that I identified the argument values that
needed to be handled with this code:

   for i, call in enumerate(case.get_value.call_args_list):
       print(f"  Call {i}: {call}")

Author: billsacks

CIME/tests/test_unit_xml_tests.py

@@ -32,16 +32,27 @@ def test_support_single_exe(self, _setup_cases_if_not_yet_done):
 
             case.get_compset_components.return_value = ()
 
-            case.get_value.side_effect = (
-                "SMS",
-                tdir,
-                f"{caseroot}",
-                "SMS.f19_g16.S",
-                "cpl",
-                "SMS.f19_g16.S",
-                f"{caseroot}",
-                "SMS.f19_g16.S",
-            )
+            def fake_get_value(item, attribute=None):
+                simple_lookup = {
+                    "TESTCASE": "SMS",
+                    "CASEROOT": f"{caseroot}",
+                    "CASEBASEID": "SMS.f19_g16.S",
+                    "COMP_INTERFACE": "cpl",
+                    "DRV_RESTART_POINTER": None,
+                }
+                if item in simple_lookup:
+                    return simple_lookup[item]
+                elif item == "SYSTEM_TESTS_DIR":
+                    if attribute["component"] == "any":
+                        return tdir
+                    else:
+                        return None
+
+                raise KeyError(
+                    f"Unmocked call: case.get_value({item}, attribute={attribute})"
+                )
+
+            case.get_value.side_effect = fake_get_value
 
             tests = Tests()
 
@@ -65,17 +76,28 @@ def test_support_single_exe_error(self, _setup_cases_if_not_yet_done):
 
             case.get_compset_components.return_value = ()
 
-            case.get_value.side_effect = (
-                "ERP",
-                tdir,
-                f"{caseroot}",
-                "ERP.f19_g16.S",
-                "cpl",
-                None,
-                "ERP.f19_g16.S",
-                f"{caseroot}",
-                "ERP.f19_g16.S",
-            )
+            def fake_get_value(item, attribute=None):
+                simple_lookup = {
+                    "TESTCASE": "ERP",
+                    "CASEROOT": f"{caseroot}",
+                    "CASEBASEID": "ERP.f19_g16.S",
+                    "CASE": "ERP.f19_g16.S",
+                    "COMP_INTERFACE": "cpl",
+                    "DRV_RESTART_POINTER": None,
+                }
+                if item in simple_lookup:
+                    return simple_lookup[item]
+                elif item == "SYSTEM_TESTS_DIR":
+                    if attribute["component"] == "any":
+                        return tdir
+                    else:
+                        return None
+
+                raise KeyError(
+                    f"Unmocked call: case.get_value({item}, attribute={attribute})"
+                )
+
+            case.get_value.side_effect = fake_get_value
 
             tests = Tests()