Skip to content

Print warning when updated tag doesn't exist? #77

@nusbaume

Description

@nusbaume

When you set fxtag to a non-existent tag, git-fleximod just silently grabs the original submodule hash/tag. While I think this behavior is fine, it would be nice to print a warning to the screen that the new tag wasn't found, so that the user/developer is aware that their .gitmodules change was not correct.

To reproduce the issue:

  1. Grab a codebase (e.g. ESCOMP/CESM) that uses git-fleximod.
  2. Update the .gitmodules file so that one of the submodules has an fxtag entry that is completely made up or non-existent.
  3. Run bin/git-fleximod update, and note that it will simply ignore the bad fxtag setting and grab the original submodule tag/hash, without any sort of notification.

This was tested with the latest version of git-fleximod (v1.0.1).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions