Skip to content

Commit 7263a70

Browse files
authored
Refactor promises in wsi2.html for clarity
1 parent b1c6098 commit 7263a70

File tree

1 file changed

+7
-20
lines changed

1 file changed

+7
-20
lines changed

npachpande/cwc/local/patch/wsi2.html

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,10 @@
2828
<input type="text" id="nudgeInput"><br><br>
2929
<button type="button" onclick="sendNudge()">send nudge</button>
3030
<script type='text/javascript'>
31-
let conversationOpenedPromise, conversationOpenedPromiseResolve;
32-
let firstBotMessagePromise, firstBotMessagePromiseResolve;
3331
let oliveReadyPromise, oliveReadyPromiseResolve;
3432
let isNewConversation = false;
3533

3634
window.addEventListener("onEmbeddedMessagingReady", () => {
37-
conversationOpenedPromise = new Promise((resolve) => {
38-
conversationOpenedPromiseResolve = resolve;
39-
});
40-
firstBotMessagePromise = new Promise((resolve) => {
41-
firstBotMessagePromiseResolve = resolve;
42-
});
4335
oliveReadyPromise = new Promise((resolve) => {
4436
oliveReadyPromiseResolve = resolve;
4537
});
@@ -50,23 +42,18 @@
5042
});
5143

5244
window.addEventListener("onEmbeddedMessagingConversationOpened", () => {
53-
oliveReadyPromiseResolve = isNewConversation ? firstBotMessagePromiseResolve : conversationOpenedPromiseResolve;
54-
resolveConversationOpenedPromise();
45+
if (!isNewConversation) {
46+
resolveOliveReadyPromise();
47+
}
5548
});
5649

5750
window.addEventListener("onEmbeddedMessagingFirstBotMessageSent", () => {
58-
resolveFirstBotMessagePromise();
51+
resolveOliveReadyPromise();
5952
});
6053

61-
function resolveConversationOpenedPromise() {
62-
if (conversationOpenedPromiseResolve) {
63-
conversationOpenedPromiseResolve();
64-
}
65-
}
66-
67-
function resolveFirstBotMessagePromise() {
68-
if (firstBotMessagePromiseResolve) {
69-
firstBotMessagePromiseResolve();
54+
function resolveOliveReadyPromise() {
55+
if (oliveReadyPromiseResolve) {
56+
oliveReadyPromiseResolve();
7057
}
7158
}
7259

0 commit comments

Comments
 (0)