.slnx support and bug fix

- Added support for using the new XML format solution files (.slnx) as documentation sources.
- Fixed XML reader creation to consistently close the files so that they don't remain open and cause subsequent builds to fail because they can't be replaced.

Author: EWSoftware

.editorconfig

@@ -203,24 +203,6 @@ dotnet_diagnostic.CA1303.severity = none
 # IDE0010: Add missing cases
 dotnet_diagnostic.IDE0010.severity = none
 
-# IDE0032: Use auto property
-dotnet_diagnostic.IDE0032.severity = none
-
-# IDE0045: Convert to conditional expression
-dotnet_diagnostic.IDE0045.severity = none
-
-# IDE0046: Convert to conditional expression
-dotnet_diagnostic.IDE0046.severity = none
-
-# IDE0047: Remove unnecessary parentheses
-dotnet_diagnostic.IDE0047.severity = none
-
-# IDE0055: Fix formatting
-dotnet_diagnostic.IDE0055.severity = none
-
-# IDE0058: Expression value is never used
-dotnet_diagnostic.IDE0058.severity = none
-
 # IDE1006: Naming Styles
 dotnet_diagnostic.IDE1006.severity = none
 
@@ -255,6 +237,7 @@ dotnet_diagnostic.CA1846.severity = none
 csharp_style_var_elsewhere = false:none
 csharp_style_var_for_built_in_types = false:none
 csharp_style_var_when_type_is_apparent = false:none
+csharp_style_prefer_primary_constructors = false:none
 
 csharp_style_expression_bodied_accessors = true:suggestion
 csharp_style_expression_bodied_constructors = false:none

SHFB/Source/BuildAssembler/BuildComponents/Commands/IndexedCache.cs

@@ -179,7 +179,10 @@ private XPathDocument LoadXmlCommentsFile(string filename)
 
             try
             {
-                document = new XPathDocument(XmlReader.Create(filename, new XmlReaderSettings { CloseInput = true }));
+                using(var rdr = XmlReader.Create(filename, new XmlReaderSettings { CloseInput = true }))
+                {
+                    document = new XPathDocument(rdr);
+                }
 
                 // For XML comments files, some versions of the framework redirect the comments files to a
                 // common location.
@@ -206,7 +209,12 @@ private XPathDocument LoadXmlCommentsFile(string filename)
                         document = null;
                     }
                     else
-                        document = new XPathDocument(XmlReader.Create(path, new XmlReaderSettings { CloseInput = true }));
+                    {
+                        using(var rdr = XmlReader.Create(path, new XmlReaderSettings { CloseInput = true }))
+                        {
+                            document = new XPathDocument(rdr);
+                        }
+                    }
                 }
             }
             catch(IOException e)

SHFB/Source/BuildAssembler/BuildComponents/CopyFromFileComponent.cs

@@ -95,7 +95,7 @@ public override void Initialize(XPathNavigator configuration)
                 // Load a schema, if one is specified
                 string schemaFile = dataNode.GetAttribute("schema", String.Empty);
 
-                XmlReaderSettings settings = new XmlReaderSettings();
+                XmlReaderSettings settings = new XmlReaderSettings { CloseInput = true };
 
                 if(!String.IsNullOrWhiteSpace(schemaFile))
                     settings.Schemas.Add(null, schemaFile);

SHFB/Source/BuildAssembler/BuildComponents/ExampleComponent.cs

@@ -96,7 +96,7 @@ private void LoadContent(string file)
 
             try
             {
-                XmlReaderSettings settings = new XmlReaderSettings { CheckCharacters = false };
+                XmlReaderSettings settings = new XmlReaderSettings { CheckCharacters = false, CloseInput = true };
                 XmlReader reader = XmlReader.Create(file, settings);
 
                 try

SHFB/Source/BuildAssembler/BuildComponents/IntelliSenseComponent.cs

@@ -392,7 +392,7 @@ private void WriteComments()
                     if(!writers.TryGetValue(comments.AssemblyName, out XmlWriter writer))
                     {
                         fullPath = Path.Combine(outputFolder, comments.AssemblyName + ".xml");
-                        XmlWriterSettings settings = new XmlWriterSettings { Indent = true };
+                        XmlWriterSettings settings = new XmlWriterSettings { Indent = true, CloseOutput = true };
 
                         try
                         {

SHFB/Source/BuildAssembler/BuildComponents/SaveComponent.cs

@@ -53,7 +53,7 @@ public override BuildComponentCore Create()
         #region Private data members
         //=====================================================================
 
-        private readonly XmlWriterSettings settings = new XmlWriterSettings();
+        private readonly XmlWriterSettings settings = new XmlWriterSettings { CloseOutput = true };
         private XPathExpression pathExpression, selectExpression;
 
         private string basePath, groupId;

SHFB/Source/BuildAssembler/BuildComponents/SharedContentComponent.cs

@@ -258,7 +258,7 @@ private void LoadContent(string file)
 
             try
             {
-                using(XmlReader reader = XmlReader.Create(file))
+                using(XmlReader reader = XmlReader.Create(file, new XmlReaderSettings { CloseInput = true }))
                 {
                     reader.MoveToContent();
 

SHFB/Source/BuildAssembler/BuildComponents/Targets/TargetTypeDictionary.cs

@@ -264,7 +264,7 @@ public void DumpTargetDictionary(string targetsFile)
         {
             LinkTextResolver resolver = new LinkTextResolver(this);
 
-            XmlWriterSettings settings = new XmlWriterSettings { Indent = true };
+            XmlWriterSettings settings = new XmlWriterSettings { Indent = true, CloseOutput = true };
 
             using(XmlWriter writer = XmlWriter.Create(targetsFile, settings))
             {

SHFB/Source/BuildAssembler/SyntaxComponents/XamlUsageSyntax.cs

@@ -232,7 +232,7 @@ private void ParseDocument(string file)
         {
             try
             {
-                using(var xr = XmlReader.Create(file, new XmlReaderSettings()))
+                using(var xr = XmlReader.Create(file, new XmlReaderSettings { CloseInput = true }))
                 {
                     XPathDocument document = new XPathDocument(xr);
 

SHFB/Source/CodeColorizer/ColorizerLibrary/CodeColorizer.cs

@@ -1121,7 +1121,7 @@ private void BuildSyntax()
         {
             XmlNode needBuildNode, highlightNode;
 
-            using(var reader = XmlReader.Create(this.LanguageSyntaxFileName, new XmlReaderSettings()))
+            using(var reader = XmlReader.Create(this.LanguageSyntaxFileName, new XmlReaderSettings { CloseInput = true }))
             {
                 languageSyntax.Load(reader);
             }