Type all iterable

Author: javiereguiluz

phpstan.neon.dist

@@ -19,8 +19,6 @@ parameters:
         - '#Property EasyCorp\\Bundle\\EasyAdminBundle\\Twig\\EasyAdminTwigExtension::\$uxIconRuntime has unknown class Symfony\\UX\\Icons\\Twig\\UXIconRuntime as its type#'
         - '#Parameter \$uxIconRuntime of method EasyCorp\\Bundle\\EasyAdminBundle\\Twig\\EasyAdminTwigExtension::__construct\(\) has invalid type Symfony\\UX\\Icons\\Twig\\UXIconRuntime#'
         - '#Call to method renderIcon\(\) on an unknown class Symfony\\UX\\Icons\\Twig\\UXIconRuntime#'
-        -
-            identifier: missingType.iterableValue
         -
             identifier: missingType.generics
     treatPhpDocTypesAsCertain: false

src/Attribute/AdminAction.php

@@ -8,6 +8,9 @@
 #[\Attribute(\Attribute::TARGET_METHOD)]
 class AdminAction
 {
+    /**
+     * @param array<string> $methods
+     */
     public function __construct(
         public ?string $routePath = null,
         public ?string $routeName = null,

src/Config/Actions.php

@@ -75,6 +75,9 @@ public function remove(string $pageName, string $actionName): self
         return $this;
     }
 
+    /**
+     * @param array<string> $orderedActionNames
+     */
     public function reorder(string $pageName, array $orderedActionNames): self
     {
         $newActionOrder = [];
@@ -109,7 +112,7 @@ public function setPermission(string $actionName, string|Expression $permission)
     }
 
     /**
-     * @param array $permissions Syntax: ['actionName' => 'actionPermission', ...]
+     * @param array<string, string|Expression> $permissions Syntax: ['actionName' => 'actionPermission', ...]
      */
     public function setPermissions(array $permissions): self
     {

src/Config/Asset.php

@@ -107,6 +107,9 @@ public function htmlAttr(string $attrName, string $attrValue): self
         return $this;
     }
 
+    /**
+     * @param array<string, string> $attrNamesAndValues
+     */
     public function htmlAttrs(array $attrNamesAndValues): self
     {
         foreach ($attrNamesAndValues as $attrName => $attrValue) {

src/Config/Dashboard.php

@@ -110,6 +110,9 @@ public function setDefaultColorScheme(string $colorScheme): self
         return $this;
     }
 
+    /**
+     * @param array<Locale|string> $locales
+     */
     public function setLocales(array $locales): self
     {
         $localeDtos = [];

src/Config/Menu/MenuItemTrait.php

@@ -58,12 +58,13 @@ public function setLinkTarget(string $target): self
     }
 
     /**
-     * @param mixed  $content This is rendered as the value of the badge; it can be anything that can be cast to
-     *                        a string (numbers, stringable objects, etc.)
-     * @param string $style   Pass one of these values for predefined styles: 'primary', 'secondary', 'success',
-     *                        'danger', 'warning', 'info', 'light', 'dark'
-     *                        Otherwise, the passed value is applied "as is" to the `style` attribute of the HTML
-     *                        element of the badge
+     * @param mixed                $content        This is rendered as the value of the badge; it can be anything that can be cast to
+     *                                             a string (numbers, stringable objects, etc.)
+     * @param string               $style          Pass one of these values for predefined styles: 'primary', 'secondary', 'success',
+     *                                             'danger', 'warning', 'info', 'light', 'dark'
+     *                                             Otherwise, the passed value is applied "as is" to the `style` attribute of the HTML
+     *                                             element of the badge
+     * @param array<string, mixed> $htmlAttributes
      */
     public function setBadge(/* \Stringable|string|int|float|bool|null */ $content, string $style = 'secondary', array $htmlAttributes = []): self
     {

src/Config/Menu/RouteMenuItem.php

@@ -15,6 +15,9 @@ final class RouteMenuItem implements MenuItemInterface
 {
     use MenuItemTrait;
 
+    /**
+     * @param array<string, mixed> $routeParameters
+     */
     public function __construct(TranslatableInterface|string $label, ?string $icon, string $routeName, array $routeParameters)
     {
         $this->dto = new MenuItemDto();

src/Config/MenuItem.php

@@ -54,7 +54,8 @@ public static function linkToLogout(TranslatableInterface|string $label, ?string
     }
 
     /**
-     * @param string|null $icon The full CSS classes of the FontAwesome icon to render (see https://fontawesome.com/v6/search?m=free)
+     * @param string|null          $icon            The full CSS classes of the FontAwesome icon to render (see https://fontawesome.com/v6/search?m=free)
+     * @param array<string, mixed> $routeParameters
      */
     public static function linkToRoute(TranslatableInterface|string $label, ?string $icon, string $routeName, array $routeParameters = []): RouteMenuItem
     {

src/Context/ExceptionContext.php

@@ -11,9 +11,13 @@ final class ExceptionContext
 {
     private string $publicMessage;
     private string $debugMessage;
+    /** @var array<string> */
     private array $parameters;
     private int $statusCode;
 
+    /**
+     * @param array<string> $parameters
+     */
     public function __construct(string $publicMessage, string $debugMessage = '', array $parameters = [], int $statusCode = 500)
     {
         $this->publicMessage = $publicMessage;
@@ -32,11 +36,17 @@ public function getDebugMessage(): string
         return $this->debugMessage;
     }
 
+    /**
+     * @return array<string>
+     */
     public function getParameters(): array
     {
         return $this->parameters;
     }
 
+    /**
+     * @return array<string>
+     */
     public function getTranslationParameters(): array
     {
         return array_map(

src/Contracts/Filter/FilterConfiguratorInterface.php

@@ -12,7 +12,13 @@
  */
 interface FilterConfiguratorInterface
 {
+    /**
+     * @param AdminContext $context This will change to AdminContextInterface in the next major version
+     */
     public function supports(FilterDto $filterDto, ?FieldDto $fieldDto, EntityDto $entityDto, AdminContext $context): bool;
 
+    /**
+     * @param AdminContext $context This will change to AdminContextInterface in the next major version
+     */
     public function configure(FilterDto $filterDto, ?FieldDto $fieldDto, EntityDto $entityDto, AdminContext $context): void;
 }