Maniac: Global Save - Several issues

[Mimigris]

Player platform:

Windows, 64 bits continuous build of the Player.

Describe the issue in detail and how to reproduce it:

• When launching a Maniac patch game and that the global save file exists (Save.lgs), it should be automatically (re)loaded when starting the game, after a game reset or when loading a save, without using any Control Global Save command. Currently this behaviour is incorrect and the global save file is automatically loaded only once when starting the game for the first during a game session.
• When Opening a Global Save without closing it or Copying to/from the Global Save without Closing the Global Save and then closing the game without resetting or loading a save, the global save file should be created or updated with the content of the global save that was in memory, but currently EasyRPG does not do that.
• Closing the Global Save using the command in the Maniac Patch should load the content from the Save.lgs file (hence the name...) while currently EasyRPG applies this to the Open Global Save command.
• Loading the global save using Open Global Save in EasyRPG (not the intended as mentioned above but that's not the issue here) will reload the previous global save file that used to be present instead of loading null values if the Save.lgs file is removed after loading it once.

Since understanding this command is complex, I've listed as Needs feedback. My tests were done with the latest public version of the Maniac Patch 211010.

[Ghabry]

I didn't see this issue here when I worked on global save again. Some of the issues should be fixed by now... Needs testing

[Mimigris]

• I was a bit incorrect for the first point: it seems that Maniac doesn't load the global save directly on load of a game/save, but rather when the command is used -> if a global save is missing when loading the game, but is readded just before a command of this kind is called, its data will still be read. Resetting the game or closing it and reopening it on the Player seems to now reload the global save, but this still doesn't work for loading a save file.
• For the third point, it would be more correct to say that currently, it seems that both Open Global Save and Close Global Save do the same thing on EasyRPG (aka reload the global save), unless there is a difference between those two in their current implementation (?).
• The second and fourth points still stand.

I tested all of this on the continuous build of the Player, so unless it was tied to a specific pull request not yet applied it doesn't seem that much has moved.