change feedack name to feedback.enabled (microsoft#244677)

change to enabled feedback

Author: justschen

src/vs/platform/telemetry/common/telemetryService.ts

@@ -227,12 +227,12 @@ configurationRegistry.registerConfiguration({
 				description: localize('telemetry.telemetryLevel.policyDescription', "Controls the level of telemetry."),
 			}
 		},
-		'telemetry.disableFeedback': {
+		'telemetry.feedback.enabled': {
 			type: 'boolean',
-			default: false,
-			description: localize('telemetry.disableFeedback', "Disable feedback options."),
+			default: true,
+			description: localize('telemetry.feedback.enabled', "Enable feedback mechanisms such as the issue reporter, surveys, and feedback options in features like Copilot Chat."),
 			policy: {
-				name: 'DisableFeedback',
+				name: 'EnableFeedback',
 				minimumVersion: '1.99',
 			}
 		},

src/vs/workbench/contrib/chat/browser/actions/chatTitleActions.ts

@@ -41,7 +41,7 @@ import { ChatViewPane } from '../chatViewPane.js';
 import { CHAT_CATEGORY } from './chatActions.js';
 
 export const MarkUnhelpfulActionId = 'workbench.action.chat.markUnhelpful';
-const disableFeedbackConfig = 'config.telemetry.disableFeedback';
+const enableFeedbackConfig = 'config.telemetry.feedback.enabled';
 
 export function registerChatTitleActions() {
 	registerAction2(class MarkHelpfulAction extends Action2 {
@@ -57,12 +57,12 @@ export function registerChatTitleActions() {
 					id: MenuId.ChatMessageFooter,
 					group: 'navigation',
 					order: 1,
-					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ChatContextKeys.responseHasError.negate(), ContextKeyExpr.has(disableFeedbackConfig).negate())
+					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ChatContextKeys.responseHasError.negate(), ContextKeyExpr.has(enableFeedbackConfig))
 				}, {
 					id: MENU_INLINE_CHAT_WIDGET_SECONDARY,
 					group: 'navigation',
 					order: 1,
-					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ChatContextKeys.responseHasError.negate(), ContextKeyExpr.has(disableFeedbackConfig).negate())
+					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ChatContextKeys.responseHasError.negate(), ContextKeyExpr.has(enableFeedbackConfig))
 				}]
 			});
 		}
@@ -104,12 +104,12 @@ export function registerChatTitleActions() {
 					id: MenuId.ChatMessageFooter,
 					group: 'navigation',
 					order: 2,
-					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ContextKeyExpr.has(disableFeedbackConfig).negate())
+					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ContextKeyExpr.has(enableFeedbackConfig))
 				}, {
 					id: MENU_INLINE_CHAT_WIDGET_SECONDARY,
 					group: 'navigation',
 					order: 2,
-					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ChatContextKeys.responseHasError.negate(), ContextKeyExpr.has(disableFeedbackConfig).negate())
+					when: ContextKeyExpr.and(ChatContextKeys.isResponse, ChatContextKeys.responseHasError.negate(), ContextKeyExpr.has(enableFeedbackConfig))
 				}]
 			});
 		}
@@ -156,12 +156,12 @@ export function registerChatTitleActions() {
 					id: MenuId.ChatMessageFooter,
 					group: 'navigation',
 					order: 3,
-					when: ContextKeyExpr.and(ChatContextKeys.responseSupportsIssueReporting, ChatContextKeys.isResponse, ContextKeyExpr.has(disableFeedbackConfig).negate())
+					when: ContextKeyExpr.and(ChatContextKeys.responseSupportsIssueReporting, ChatContextKeys.isResponse, ContextKeyExpr.has(enableFeedbackConfig))
 				}, {
 					id: MENU_INLINE_CHAT_WIDGET_SECONDARY,
 					group: 'navigation',
 					order: 3,
-					when: ContextKeyExpr.and(ChatContextKeys.responseSupportsIssueReporting, ChatContextKeys.isResponse, ContextKeyExpr.has(disableFeedbackConfig).negate())
+					when: ContextKeyExpr.and(ChatContextKeys.responseSupportsIssueReporting, ChatContextKeys.isResponse, ContextKeyExpr.has(enableFeedbackConfig))
 				}]
 			});
 		}

src/vs/workbench/contrib/issue/common/issue.contribution.ts

@@ -66,7 +66,7 @@ export class BaseIssueContribution extends Disposable implements IWorkbenchContr
 	) {
 		super();
 
-		if (configurationService.getValue<boolean>('telemetry.disableFeedback')) {
+		if (!configurationService.getValue<boolean>('telemetry.feedback.enabled')) {
 			this._register(CommandsRegistry.registerCommand({
 				id: 'workbench.action.openIssueReporter',
 				handler: function (accessor) {

src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts

@@ -35,7 +35,7 @@ class NativeIssueContribution extends BaseIssueContribution {
 	) {
 		super(productService, configurationService);
 
-		if (configurationService.getValue<boolean>('telemetry.disableFeedback')) {
+		if (!configurationService.getValue<boolean>('telemetry.feedback.enabled')) {
 			return;
 		}
 

src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts

@@ -31,7 +31,7 @@ interface IConfiguration extends IWindowsConfiguration {
 	security?: { workspace?: { trust?: { enabled?: boolean } }; restrictUNCAccess?: boolean };
 	window: IWindowSettings;
 	workbench?: { enableExperiments?: boolean };
-	telemetry?: { disableFeedback?: boolean };
+	telemetry?: { feedback?: { enabled?: boolean } };
 	_extensionsGallery?: { enablePPE?: boolean };
 	accessibility?: { verbosity?: { debug?: boolean } };
 	chat?: { unifiedChatView?: boolean; useFileStorage?: boolean };
@@ -54,7 +54,7 @@ export class SettingsChangeRelauncher extends Disposable implements IWorkbenchCo
 		'accessibility.verbosity.debug',
 		ChatConfiguration.UnifiedChatView,
 		ChatConfiguration.UseFileStorage,
-		'telemetry.disableFeedback'
+		'telemetry.feedback.enabled'
 	];
 
 	private readonly titleBarStyle = new ChangeObserver<TitlebarStyle>('string');
@@ -71,7 +71,7 @@ export class SettingsChangeRelauncher extends Disposable implements IWorkbenchCo
 	private readonly accessibilityVerbosityDebug = new ChangeObserver('boolean');
 	private readonly unifiedChatView = new ChangeObserver('boolean');
 	private readonly useFileStorage = new ChangeObserver('boolean');
-	private readonly telemetryDisableFeedback = new ChangeObserver('boolean');
+	private readonly telemetryFeedbackEnabled = new ChangeObserver('boolean');
 
 	constructor(
 		@IHostService private readonly hostService: IHostService,
@@ -161,8 +161,8 @@ export class SettingsChangeRelauncher extends Disposable implements IWorkbenchCo
 		// Profiles
 		processChanged(this.productService.quality !== 'stable' && this.enablePPEExtensionsGallery.handleChange(config._extensionsGallery?.enablePPE));
 
-		// Disable Feedback
-		processChanged(this.telemetryDisableFeedback.handleChange(config.telemetry?.disableFeedback));
+		// Enable Feedback
+		processChanged(this.telemetryFeedbackEnabled.handleChange(config.telemetry?.feedback?.enabled));
 
 		if (askToRelaunch && changed && this.hostService.hasFocus) {
 			this.doConfirm(

src/vs/workbench/contrib/surveys/browser/nps.contribution.ts

@@ -33,7 +33,7 @@ class NPSContribution implements IWorkbenchContribution {
 		@IProductService productService: IProductService,
 		@IConfigurationService configurationService: IConfigurationService
 	) {
-		if (!productService.npsSurveyUrl || configurationService.getValue<boolean>('telemetry.disableFeedback')) {
+		if (!productService.npsSurveyUrl || !configurationService.getValue<boolean>('telemetry.feedback.enabled')) {
 			return;
 		}