Custom "append to playlist" api route

[sapristi]

Hello,
would you be interested in supporting a "append to playlist" custom API route ? I've tried to launch the idea in mopidy core, but I'm not sure it'll make it (see mopidy/mopidy#2184 ).

I'd like to add the feature to https://github.com/sapristi/mopidy-mowecl, as this is a pattern that I regularly use.

[tehkillerbee]

Should be possible, as I have already added the necessary functionality to python-tidal / tidalapi to allow appending (or adding at an arbitrary offset)

https://github.com/tamland/python-tidal/blob/18e7c47eb85aa2f3e2c7432f36af79a38f80ac3e/tidalapi/playlist.py#L485

[sapristi]

All right, I got something working : master...sapristi:mopidy-tidal:master

I'll improve on that and keep you up !

[sapristi]

Ok I finally got something ready to be used (still needs to figure some stuff about CORS headers / remote checking) !

I have one question: I needed to call backend.playlists._playlists.prune(playlist_uri), otherwise the playlist is not refreshed. Do you expect it to be this way ?

        upstream_playlist = backend.session.playlist(playlist_id)
        res = upstream_playlist.add(track_ids)
        backend.playlists._playlists.prune(playlist_uri) # If I don't do this, the playlist does not seem to get refreshed

Note: I realized that this does not need to be bundled in the mopidy-tidal extension, so I could include this directly in my client in case this does not fit here.

[sapristi]

It's added in mowecl, please let me know if you consider including it here :)

[tehkillerbee]

@sapristi So if I understand you correctly, you want a way to add individual tracks to a playlist and since this is not currently supported by mopidy, you want this feature added directly to mopidy-tidal?

TBH, it does sound a little too hacky for my taste. I would much rather have the necessary functionality added to mopidy, then we can add the support to mopidy-tidal as well.

Generally, I think the mopidy playlist editing is lacking, while the underlying API (tidalapi) supports many different ways to modify playlists (adding one or more tracks at arbitary indices).

[sapristi]

Yes I agree it would be best to add this kind of interface to mopidy.

[blacklight]

Note that I already implemented the save method on mopidy-tidal.

The save method is correctly called by MPD clients (tested with ncmpcpp), but mileage may vary with other clients - for example IIRC mopidy-iris can add items to Spotify playlists by completely bypassing Mopidy's APIs and calling the Spotify API directly, so it really depends on what kind of client we're talking about and what kind of interaction it expects.

The save method in particular isn't to append items, the MPD implementation wants the full snapshot of the new playlist, so if you want to append something you'll have to pass [...everything-else..., your-new-item] to it.