Switching between models may crash ARKit #28

Author: EddyVerbruggen

Diff for: demo/app/App_Resources/iOS/Models.scnassets/glasses-vv-1.dae

@@ -151,7 +151,7 @@ export function arLoaded(args: ARLoadedEventData): void {
 
 export function trackingFaceDetected(args: ARTrackingFaceEventData): void {
   if (args.properties) {
-    console.log(JSON.stringify(args.properties));
+    // console.log(JSON.stringify(args.properties));
   }
 
   if (args.faceTrackingActions) {
@@ -177,16 +177,16 @@ export function trackingFaceDetected(args: ARTrackingFaceEventData): void {
     }, 500);
 
     args.faceTrackingActions.addModel({
-      name: "Models.scnassets/glasses2.obj",
+      name: "Models.scnassets/glasses-vv-1.dae",
       position: {
-        x: 0,
-        y: -0.007, // a little lower
-        z: 0.06 // a little closer to the camera
+        x: 0.001,
+        y: 0.01,
+        z: 0
       },
       scale: {
-        x: 0.0045,
-        y: 0.0045,
-        z: 0.0045
+        x: 1.03,
+        y: 1.03,
+        z: 1.03
       },
       onTap: (interaction: ARNodeInteraction) => {
         // let's remove the current glasses, and replace it by a different model
@@ -210,7 +210,7 @@ export function trackingFaceDetected(args: ARTrackingFaceEventData): void {
           }
         });
 
-        textModel.remove();
+        // textModel.remove();
         args.faceTrackingActions.addText({
           text: "Ray-Ban Opaque",
           materials: [new Color("orange")],

Diff for: demo/app/main-page.ts

@@ -14,8 +14,8 @@
         trackingImageDetected="trackingImageDetected"
         trackingFaceDetected="trackingFaceDetected"
         debugLevel="FEATURE_POINTS"
-        faceMaterial="Assets.scnassets/Materials/tnsgranite/tnsgranite-diffuse.png"
-        faceMaterial__DISABLED="Assets.xcassets/wireframeTexture.imageset"
+        faceMaterial__DISABLED="Assets.scnassets/Materials/tnsgranite/tnsgranite-diffuse.png"
+        faceMaterial__DISABLED2="Assets.xcassets/wireframeTexture.imageset"
         planeMaterial="{{ planeMaterial }}"
         planeOpacity="0.25"
         detectPlanes="true"

Diff for: demo/app/main-page.xml

@@ -2,10 +2,18 @@ import { ARAddModelOptions } from "../../ar-common";
 import { ARCommonNode } from "./arcommon";
 
 export class ARModel extends ARCommonNode {
-  // note that these babies can be cloned, look for 'clone' at http://jamesonquave.com/blog/arkit-tutorial-in-swift-4-for-xcode-9-using-scenekit/
   static create(options: ARAddModelOptions) {
     let modelScene = SCNScene.sceneNamed(options.name);
-    let nodeModel = options.childNodeName ? modelScene.rootNode.childNodeWithNameRecursively(options.childNodeName, true) : modelScene.rootNode;
-    return new ARModel(options, nodeModel);
+
+    let nodeModel: SCNNode;
+    if (options.childNodeName) {
+      nodeModel = modelScene.rootNode.childNodeWithNameRecursively(options.childNodeName, true);
+    } else if (modelScene.rootNode.childNodes.count === 1) {
+      nodeModel = modelScene.rootNode.childNodes.objectAtIndex(0);
+    } else {
+      nodeModel = modelScene.rootNode;
+    }
+
+    return new ARModel(options, nodeModel.clone());
   }
 }

Diff for: src/nodes/ios/armodel.ts

@@ -1,6 +1,6 @@
 {
   "name": "nativescript-ar",
-  "version": "0.7.2",
+  "version": "0.8.0",
   "description": "NativeScript Augmented Reality plugin. ARKit on iOS and (in the future) ARCore on Android.",
   "main": "ar",
   "typings": "index.d.ts",