-
Notifications
You must be signed in to change notification settings - Fork 51
ZIP-321 URI Support #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIP-321 URI Support #1004
Conversation
💡 Codex Reviewedge-currency-accountbased/src/zcash/ZcashEngine.ts Lines 462 to 466 in 995f06a
When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
src/zcash/ZcashEngine.ts
Outdated
| } | ||
|
|
||
| const proposal = | ||
| zip321Uri != null && synchronizer?.proposeFulfillingPaymentURI != null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The synchronizer?.proposeFulfillingPaymentURI != null is unnecessary as it's required in the type
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Adds Zcash ZIP-321 Payment URI handling by routing makeSpend to
proposeFulfillingPaymentURIand wiring the method through the Zcash IO bridge.ZcashEngine.makeSpendnow detectsedgeSpendInfo.otherParams.zip321Uriand callssynchronizer.proposeFulfillingPaymentURI(...); otherwise falls back toproposeTransfer.ZcashSynchronizerwithproposeFulfillingPaymentURI(paymentUri)and proxy to nativereact-native-zcashsynchronizer.CHANGELOG.md: add "(Zcash) ZIP-321 URI support" under Unreleased.Written by Cursor Bugbot for commit 22a8e08. This will update automatically on new commits. Configure here.