Skip to content

Conversation

@BrianBHuynh
Copy link
Contributor

Adds POWER_LED_BLUE to Flags since it was recently added in February and a decent amount of people seem to be interested (me included) according to EdgeTX/edgetx#5010

Adds POWER_LED_BLUE to Flags since it was recently added in February and a decent amount of people seem to be interested (me included) according to EdgeTX/edgetx#5010
@BrianBHuynh
Copy link
Contributor Author

Huh does anyone know why I may be getting 403 forbidden as an error for my pull request? It seems like everything else was fine other than pushing to ghcr.io

@BrianBHuynh
Copy link
Contributor Author

Ah I noticed a message on the discord just now saying that this wasn't in line with the vision that the devs currently have, I'll be closing out this pull request then in that case!

@pfeerick
Copy link
Member

pfeerick commented Apr 16, 2025

No, no, no... this PR is fine... the comment on Discord was in relation to someone else talking about going to multi-colour and changing all the colours around / multi-colour... this one is fine since it only exposes the flag allowing that single colour change.

I think the 403 is due to a permissions error... action is probably not taking into account the PR could be coming from a fork, and trying to push to edgetx docker storage... which should not be happening.

@pfeerick pfeerick reopened this Apr 16, 2025
@pfeerick pfeerick changed the title Added power led blue flag to cloud build feat: add power led blue flag to cloud build Apr 17, 2025
@pfeerick pfeerick merged commit ae1079e into EdgeTX:master Apr 17, 2025
3 of 4 checks passed
@BrianBHuynh
Copy link
Contributor Author

LESSGOOOO :D sorry I thought the comment on discord was towards me but I'm glad the commit was okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants