fix: improve testing setup

- Use a new environment variable called `TESTDIR` in `skll.utils.testing` as an alternative
to hard-coding the path to the `tests` directory. This is needed when running tests as part
of testing the conda and PyPI packages.
- Tweak some path based tests to use absoluate paths when comparing.

Author: desilinguist

skll/utils/testing.py

@@ -1,6 +1,7 @@
 """Utility functions to make SKLL testing simpler."""
 
 
+import os
 import re
 from collections import OrderedDict
 from math import floor, log10
@@ -23,7 +24,10 @@
 from skll.data import FeatureSet, NDJWriter
 from skll.types import PathOrStr
 
-tests_dir = Path(__file__).resolve().parent.parent.parent / "tests"
+if env_test_dir := os.getenv("TESTDIR"):
+    tests_dir = Path(env_test_dir) / "tests"
+else:
+    tests_dir = Path(__file__).resolve().parent.parent.parent / "tests"
 config_dir = tests_dir / "configs"
 backward_compatibility_dir = tests_dir / "backward_compatibility"
 examples_dir = tests_dir.parent / "examples"

tests/test_input.py

@@ -85,26 +85,27 @@ def test_locate_file_valid_paths1(self):
         """Test that `config.locate_file` works with absolute paths."""
         config_abs_path = config_dir / "test_config_parsing_relative_path1.cfg"
         open(config_abs_path, "w").close()
-        self.assertEqual(
-            locate_file(config_abs_path, tests_dir),
-            str(config_dir / "test_config_parsing_relative_path1.cfg"),
-        )
+        computed_path = locate_file(config_abs_path, tests_dir)
+        expected_path = str(config_dir / "test_config_parsing_relative_path1.cfg")
+        self.assertEqual(Path(computed_path).resolve(), Path(expected_path).resolve())
 
     def test_locate_file_valid_paths2(self):
         """Test that `config.locate_file` works with relative paths."""
         config_abs_path = config_dir / "test_config_parsing_relative_path2.cfg"
         config_rel_path = "configs/test_config_parsing_relative_path2.cfg"
         open(config_abs_path, "w").close()
-        self.assertEqual(locate_file(config_rel_path, tests_dir), str(config_abs_path))
+        computed_path = locate_file(config_rel_path, tests_dir)
+        expected_path = str(config_abs_path)
+        self.assertEqual(Path(computed_path).resolve(), Path(expected_path).resolve())
 
     def test_locate_file_valid_paths3(self):
         """Test that `config.locate_file` works with relative/absolute paths."""
         config_abs_path = config_dir / "test_config_parsing_relative_path3.cfg"
         config_rel_path = "configs/test_config_parsing_relative_path3.cfg"
         open(config_abs_path, "w").close()
-        self.assertEqual(
-            locate_file(config_abs_path, tests_dir), locate_file(config_rel_path, tests_dir)
-        )
+        computed_path = locate_file(config_abs_path, tests_dir)
+        expected_path = locate_file(config_rel_path, tests_dir)
+        self.assertEqual(Path(computed_path).resolve(), Path(expected_path).resolve())
 
     def test_locate_file_invalid_path(self):
         """Test that `config.locate_file` raises error for paths that do not exist."""