From 6977f3d41e6d4887d643019410552422acd64ccc Mon Sep 17 00:00:00 2001 From: "Daniel T. Plop" Date: Thu, 19 Mar 2020 15:04:11 +0100 Subject: [PATCH 1/2] update deprecated method names: 'step' and 'reset' rather than '_step' and '_reset' --- gym_puddle/envs/puddle_env.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gym_puddle/envs/puddle_env.py b/gym_puddle/envs/puddle_env.py index 2752ca4..c3f07c2 100644 --- a/gym_puddle/envs/puddle_env.py +++ b/gym_puddle/envs/puddle_env.py @@ -32,7 +32,7 @@ def _seed(self, seed=None): self.np_random, seed = seeding.np_random(seed) return [seed] - def _step(self, action): + def step(self, action): assert self.action_space.contains(action), "%r (%s) invalid"%(action, type(action)) self.pos += self.actions[action] + self.np_random.uniform(low=-self.noise, high=self.noise, size=(2,)) @@ -55,7 +55,7 @@ def _get_reward(self, pos): def _gaussian1d(self, p, mu, sig): return np.exp(-((p - mu)**2)/(2.*sig**2)) / (sig*np.sqrt(2.*np.pi)) - def _reset(self): + def reset(self): if self.start is None: self.pos = self.observation_space.sample() else: From 6e2001e250fe364323239f4542946e2d5b92148a Mon Sep 17 00:00:00 2001 From: "Daniel T. Plop" Date: Thu, 19 Mar 2020 15:29:41 +0100 Subject: [PATCH 2/2] update all deprecated method names: 'seed' and 'render' rather than '_seed' and '_render' --- gym_puddle/envs/puddle_env.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gym_puddle/envs/puddle_env.py b/gym_puddle/envs/puddle_env.py index c3f07c2..832c178 100644 --- a/gym_puddle/envs/puddle_env.py +++ b/gym_puddle/envs/puddle_env.py @@ -25,10 +25,10 @@ def __init__(self, start=[0.2, 0.4], goal=[1.0, 1.0], goal_threshold=0.1, for i in range(4): self.actions[i][i//2] = thrust * (i%2 * 2 - 1) - self._seed() + self.seed() self.viewer = None - def _seed(self, seed=None): + def seed(self, seed=None): self.np_random, seed = seeding.np_random(seed) return [seed] @@ -62,7 +62,7 @@ def reset(self): self.pos = copy.copy(self.start) return self.pos - def _render(self, mode='human', close=False): + def render(self, mode='human', close=False): if close: if self.viewer is not None: self.viewer.close()